Shunt string-dumping functions from WebFrame to a side class.

Shunt string-dumping functions from WebFrame to a side class.

Functions like contentAsText, contentAsMarkup, and layoutTreeAsText
did not seem like they belong on the WebFrame (especially in the
OOPIF world), so I moved them over to a special utility class, called
WebFrameContentDumper.

This allowed to remove a few virtual stubs from a WebFrame subclasses
and made it more clear that these methods are mostly suitable for
testing. Also caught http://crbug.com/584798 in the process.

Ideally, no production code should be using WebFrameContentDumper.
But that's another story for another day.

Also removed markerTextForListItem, which doesn't seem to be used by anything.

R=jochen@chromium.org,nasko
BUG=

Committed: https://crrev.com/032234908562551b3d774c99a4e4498b3ec6d44d
Cr-Commit-Position: refs/heads/master@{#374201}

[dglazkov, 2016-02-06 01:13:00]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 01:14:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672073003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672073003/1

[commit-bot: I haz the power, 2016-02-06 01:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 01:28:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[dglazkov, 2016-02-06 05:25:41]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-02-06 05:25:43]

Fix compile.

[commit-bot: I haz the power, 2016-02-06 05:25:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672073003/20001

[dglazkov, 2016-02-06 05:45:50]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-02-06 05:45:51]

Whoops, exports.

[commit-bot: I haz the power, 2016-02-06 05:46:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672073003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672073003/40001

[commit-bot: I haz the power, 2016-02-06 06:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 06:49:18]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-02-06 18:00:23]

PTAL.

[dglazkov, 2016-02-06 18:04:51]

Description was changed from

==========
Shunt string-dumping functions from WebFrame to a side class.

Functions like contentAsText, contentAsMarkup, and layoutTreeAsText
did not seem like they belonged on the WebFrame (especially in the
OOPIF world), so I moved them over to a special utility class, called
WebFrameContentDumper.

This allowed to remove a few virtual stubs from a WebFrame subclasses
and made it more clear that these methods are mostly suitable for
testing. Also caught http://crbug.com/584798 in the process.

Ideally, no production code should be using WebFrameContentDumper.
But that's another story for another day.

R=jochen@chromium.org,nasko
BUG=
==========

to

==========
Shunt string-dumping functions from WebFrame to a side class.

Functions like contentAsText, contentAsMarkup, and layoutTreeAsText
did not seem like they belong on the WebFrame (especially in the
OOPIF world), so I moved them over to a special utility class, called
WebFrameContentDumper.

This allowed to remove a few virtual stubs from a WebFrame subclasses
and made it more clear that these methods are mostly suitable for
testing. Also caught http://crbug.com/584798 in the process.

Ideally, no production code should be using WebFrameContentDumper.
But that's another story for another day.

R=jochen@chromium.org,nasko
BUG=
==========

[dglazkov, 2016-02-07 04:10:27]

Description was changed from

==========
Shunt string-dumping functions from WebFrame to a side class.

Functions like contentAsText, contentAsMarkup, and layoutTreeAsText
did not seem like they belong on the WebFrame (especially in the
OOPIF world), so I moved them over to a special utility class, called
WebFrameContentDumper.

This allowed to remove a few virtual stubs from a WebFrame subclasses
and made it more clear that these methods are mostly suitable for
testing. Also caught http://crbug.com/584798 in the process.

Ideally, no production code should be using WebFrameContentDumper.
But that's another story for another day.

R=jochen@chromium.org,nasko
BUG=
==========

to

==========
Shunt string-dumping functions from WebFrame to a side class.

Functions like contentAsText, contentAsMarkup, and layoutTreeAsText
did not seem like they belong on the WebFrame (especially in the
OOPIF world), so I moved them over to a special utility class, called
WebFrameContentDumper.

This allowed to remove a few virtual stubs from a WebFrame subclasses
and made it more clear that these methods are mostly suitable for
testing. Also caught http://crbug.com/584798 in the process.

Ideally, no production code should be using WebFrameContentDumper.
But that's another story for another day.

Also removed markerTextForListItem, which doesn't seem to be used by anything.

R=jochen@chromium.org,nasko
BUG=
==========

[jam, 2016-02-08 18:09:54]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-02-08 18:09:54]

lgtm

https://codereview.chromium.org/1672073003/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebFrameContentDumper.h (right):

https://codereview.chromium.org/1672073003/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebFrameContentDumper.h:16: // testing purposes.
having this comment not match the existing usage is a bit confusing. maybe add a
todo or bug that links to something that tracks progress towards this goal?

[dglazkov, 2016-02-08 18:14:52]

https://codereview.chromium.org/1672073003/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebFrameContentDumper.h (right):

https://codereview.chromium.org/1672073003/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebFrameContentDumper.h:16: // testing purposes.
On 2016/02/08 at 18:09:54, jam wrote:
> having this comment not match the existing usage is a bit confusing. maybe add
a todo or bug that links to something that tracks progress towards this goal?

Excellent point! Will add.

[dglazkov, 2016-02-08 18:55:15]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-02-08 18:55:17]

Added/updated TODOs.

[commit-bot: I haz the power, 2016-02-08 18:56:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672073003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672073003/60001

[commit-bot: I haz the power, 2016-02-08 21:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 21:46:59]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-02-08 21:54:56]

The CQ bit was checked by dglazkov@chromium.org

[dglazkov, 2016-02-08 21:54:56]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1672073003/#ps60001
(title: "Added/updated TODOs.")

[commit-bot: I haz the power, 2016-02-08 21:58:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672073003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672073003/60001

[commit-bot: I haz the power, 2016-02-08 22:16:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-08 22:18:13]

Description was changed from

==========
Shunt string-dumping functions from WebFrame to a side class.

Functions like contentAsText, contentAsMarkup, and layoutTreeAsText
did not seem like they belong on the WebFrame (especially in the
OOPIF world), so I moved them over to a special utility class, called
WebFrameContentDumper.

This allowed to remove a few virtual stubs from a WebFrame subclasses
and made it more clear that these methods are mostly suitable for
testing. Also caught http://crbug.com/584798 in the process.

Ideally, no production code should be using WebFrameContentDumper.
But that's another story for another day.

Also removed markerTextForListItem, which doesn't seem to be used by anything.

R=jochen@chromium.org,nasko
BUG=
==========

to

==========
Shunt string-dumping functions from WebFrame to a side class.

Functions like contentAsText, contentAsMarkup, and layoutTreeAsText
did not seem like they belong on the WebFrame (especially in the
OOPIF world), so I moved them over to a special utility class, called
WebFrameContentDumper.

This allowed to remove a few virtual stubs from a WebFrame subclasses
and made it more clear that these methods are mostly suitable for
testing. Also caught http://crbug.com/584798 in the process.

Ideally, no production code should be using WebFrameContentDumper.
But that's another story for another day.

Also removed markerTextForListItem, which doesn't seem to be used by anything.

R=jochen@chromium.org,nasko
BUG=

Committed: https://crrev.com/032234908562551b3d774c99a4e4498b3ec6d44d
Cr-Commit-Position: refs/heads/master@{#374201}
==========

[commit-bot: I haz the power, 2016-02-08 22:18:15]

Patchset 4 (id:??) landed as
https://crrev.com/032234908562551b3d774c99a4e4498b3ec6d44d
Cr-Commit-Position: refs/heads/master@{#374201}