Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 1672073003: Shunt string-dumping functions from WebFrame to a side class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added/updated TODOs. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/web/WebFrameContentDumper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index f7e347df1934ef248c7eb57a120b7dde0add2ba5..438808377bdedc3727e18aaa40c89997543ba52b 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -99,14 +99,6 @@ template <typename T> class WebVector;
// getting a frame's parent or its opener.
class WebFrame {
public:
- // Control of layoutTreeAsText output
- enum LayoutAsTextControl {
- LayoutAsTextNormal = 0,
- LayoutAsTextDebug = 1 << 0,
- LayoutAsTextPrinting = 1 << 1,
- LayoutAsTextWithLineTrees = 1 << 2
- };
- typedef unsigned LayoutAsTextControls;
// FIXME: We already have blink::TextGranularity. For now we support only
// a part of blink::TextGranularity.
@@ -555,27 +547,6 @@ public:
// Utility -------------------------------------------------------------
- // Returns the contents of this frame as a string. If the text is
- // longer than maxChars, it will be clipped to that length. WARNING:
- // This function may be slow depending on the number of characters
- // retrieved and page complexity. For a typically sized page, expect
- // it to take on the order of milliseconds.
- //
- // If there is room, subframe text will be recursively appended. Each
- // frame will be separated by an empty line.
- virtual WebString contentAsText(size_t maxChars) const = 0;
-
- // Returns HTML text for the contents of this frame. This is generated
- // from the DOM.
- virtual WebString contentAsMarkup() const = 0;
-
- // Returns a text representation of the render tree. This method is used
- // to support layout tests.
- virtual WebString layoutTreeAsText(LayoutAsTextControls toShow = LayoutAsTextNormal) const = 0;
-
- // Calls markerTextForListItem() defined in core/layout/LayoutTreeAsText.h.
- virtual WebString markerTextForListItem(const WebElement&) const = 0;
-
// Prints all of the pages into the canvas, with page boundaries drawn as
// one pixel wide blue lines. This method exists to support layout tests.
virtual void printPagesWithBoundaries(WebCanvas*, const WebSize&) = 0;
« no previous file with comments | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/web/WebFrameContentDumper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698