[Sync] USS: Rename SharedModelTypeProcessor::Start and related methods.

[Sync] USS: Rename SharedModelTypeProcessor::Start and related methods.

Trying to make things clearer with the following renames:

- Start -> OnSyncStarting
- FinishStart -> ReadyToConnect
- OnConnect -> ConnectSync
- Stop -> DisconnectSync

BUG=584486
Committed: https://crrev.com/7d5eb673efe5c93dbf303e75340ec70df15561a4
Cr-Commit-Position: refs/heads/master@{#374842}

[maxbogue, 2016-02-05 00:55:10]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org, skym@chromium.org

[maxbogue, 2016-02-05 00:55:10]

PTAL, this is just a renaming CL.

[skym, 2016-02-05 15:25:20]

LGTM

Names all look great. A few suggestions to improve the comments about the
functions.

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/mo...
File sync/internal_api/public/model_type_processor.h (right):

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/mo...
sync/internal_api/public/model_type_processor.h:21: // Callback used to process
the handshake response from the worker.
Callback? Is that the best word here? Also, can this be called multiple times?

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/sh...
File sync/internal_api/public/shared_model_type_processor.h (right):

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/sh...
sync/internal_api/public/shared_model_type_processor.h:42: // Called by
DataTypeController to notify the processor that sync wants to
Can you add an explanation to why this complexity is needed. Also, can this be
called multiple times?

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/sh...
sync/internal_api/public/shared_model_type_processor.h:47: // stopping for the
model type.
Can you remove the word 'stopping' and explain what this means. Why would this
method get called, what should it do, etc.

[maxbogue, 2016-02-08 22:30:17]

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/mo...
File sync/internal_api/public/model_type_processor.h (right):

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/mo...
sync/internal_api/public/model_type_processor.h:21: // Callback used to process
the handshake response from the worker.
On 2016/02/05 15:25:20, skym wrote:
> Callback? Is that the best word here? Also, can this be called multiple times?

Done.

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/sh...
File sync/internal_api/public/shared_model_type_processor.h (right):

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/sh...
sync/internal_api/public/shared_model_type_processor.h:42: // Called by
DataTypeController to notify the processor that sync wants to
On 2016/02/05 15:25:20, skym wrote:
> Can you add an explanation to why this complexity is needed. Also, can this be
> called multiple times?

Done.

https://codereview.chromium.org/1671773002/diff/1/sync/internal_api/public/sh...
sync/internal_api/public/shared_model_type_processor.h:47: // stopping for the
model type.
On 2016/02/05 15:25:20, skym wrote:
> Can you remove the word 'stopping' and explain what this means. Why would this
> method get called, what should it do, etc.

Done.

[pavely, 2016-02-09 01:00:20]

lgtm

[maxbogue, 2016-02-10 19:54:54]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-02-10 19:54:54]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/1671773002/#ps20001
(title: "Better comments.")

[commit-bot: I haz the power, 2016-02-10 19:57:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671773002/20001

[commit-bot: I haz the power, 2016-02-10 20:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 20:07:01]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[maxbogue, 2016-02-11 00:45:44]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-02-11 00:45:45]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org,
pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/1671773002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-02-11 00:48:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671773002/40001

[commit-bot: I haz the power, 2016-02-11 02:35:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-16 22:34:14]

Description was changed from

==========
[Sync] USS: Rename SharedModelTypeProcessor::Start and related methods.

Trying to make things clearer with the following renames:

- Start -> OnSyncStarting
- FinishStart -> ReadyToConnect
- OnConnect -> ConnectSync
- Stop -> DisconnectSync

BUG=584486
==========

to

==========
[Sync] USS: Rename SharedModelTypeProcessor::Start and related methods.

Trying to make things clearer with the following renames:

- Start -> OnSyncStarting
- FinishStart -> ReadyToConnect
- OnConnect -> ConnectSync
- Stop -> DisconnectSync

BUG=584486

Committed: https://crrev.com/7d5eb673efe5c93dbf303e75340ec70df15561a4
Cr-Commit-Position: refs/heads/master@{#374842}
==========

[commit-bot: I haz the power, 2016-02-16 22:34:15]

Patchset 3 (id:??) landed as
https://crrev.com/7d5eb673efe5c93dbf303e75340ec70df15561a4
Cr-Commit-Position: refs/heads/master@{#374842}