sync/internal_api/public/model_type_processor.h - Issue 1671773002: [Sync] USS: Rename SharedModelTypeProcessor::Start and related methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/model_type_processor.h

Issue 1671773002: [Sync] USS: Rename SharedModelTypeProcessor::Start and related methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@smtp

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/non_blocking_data_type_controller_unittest.cc ('k') | sync/internal_api/public/shared_model_type_processor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/model_type_processor.h

diff --git a/sync/internal_api/public/model_type_processor.h b/sync/internal_api/public/model_type_processor.h

index 297b48f0edc7f2ffc19ea6aab1833116e2e3da28..4ab49468b8386cd671cd821a1ba29f1e0375ae3b 100644

--- a/sync/internal_api/public/model_type_processor.h

+++ b/sync/internal_api/public/model_type_processor.h

@@ -19,8 +19,11 @@ class SYNC_EXPORT ModelTypeProcessor {

ModelTypeProcessor();

virtual ~ModelTypeProcessor();

- // Callback used to process the handshake response from the worker.

- virtual void OnConnect(scoped_ptr<CommitQueue> commit_queue) = 0;

+ // Connect this processor to the sync engine via |commit_queue|. Once called,

+ // the processor will send any pending and future commits via this channel.

+ // This can only be called multiple times if the processor is disconnected

+ // (via the DataTypeController) in between.

+ virtual void ConnectSync(scoped_ptr<CommitQueue> commit_queue) = 0;

// Informs this object that some of its commit requests have been

// successfully serviced.