[Sync] USS: Define SharedModelTypeProcessorTest methods inline.

[Sync] USS: Define SharedModelTypeProcessorTest methods inline.

It's strange to declare things in one place and define them in another
within the same file. This CL does not affect any logic, it simply moves
code around. Also use namespace std to shorten code.

BUG=

Committed: https://crrev.com/e766bb6aa8822559c883690afe01b2bc7c1214d9
Cr-Commit-Position: refs/heads/master@{#374943}

[maxbogue, 2016-02-09 22:00:30]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-02-09 22:00:30]

Pavel, PTAL. This is just reorganizing the file a little for my own sanity. No
logic changes.

[pavely, 2016-02-09 23:36:50]

https://codereview.chromium.org/1680333002/diff/1/sync/internal_api/shared_mo...
File sync/internal_api/shared_model_type_processor_unittest.cc (right):

https://codereview.chromium.org/1680333002/diff/1/sync/internal_api/shared_mo...
sync/internal_api/shared_model_type_processor_unittest.cc:25: using namespace
std;
I think this is not allowed by style guide:
https://google.github.io/styleguide/cppguide.html#Namespaces

git cl lint should complain about "using namespace".

It is less critical here because this is unittest .cc file.

[maxbogue, 2016-02-11 00:46:19]

Fixed the std thing; PTAL!

https://codereview.chromium.org/1680333002/diff/1/sync/internal_api/shared_mo...
File sync/internal_api/shared_model_type_processor_unittest.cc (right):

https://codereview.chromium.org/1680333002/diff/1/sync/internal_api/shared_mo...
sync/internal_api/shared_model_type_processor_unittest.cc:25: using namespace
std;
On 2016/02/09 23:36:50, pavely wrote:
> I think this is not allowed by style guide:
> https://google.github.io/styleguide/cppguide.html#Namespaces
> 
> git cl lint should complain about "using namespace".
> 
> It is less critical here because this is unittest .cc file.

Done.

[pavely, 2016-02-11 01:01:16]

lgtm

[maxbogue, 2016-02-11 17:26:56]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-02-11 17:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1680333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1680333002/40001

[commit-bot: I haz the power, 2016-02-11 19:52:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-16 22:36:47]

Description was changed from

==========
[Sync] USS: Define SharedModelTypeProcessorTest methods inline.

It's strange to declare things in one place and define them in another
within the same file. This CL does not affect any logic, it simply moves
code around. Also use namespace std to shorten code.

BUG=
==========

to

==========
[Sync] USS: Define SharedModelTypeProcessorTest methods inline.

It's strange to declare things in one place and define them in another
within the same file. This CL does not affect any logic, it simply moves
code around. Also use namespace std to shorten code.

BUG=

Committed: https://crrev.com/e766bb6aa8822559c883690afe01b2bc7c1214d9
Cr-Commit-Position: refs/heads/master@{#374943}
==========

[commit-bot: I haz the power, 2016-02-16 22:36:47]

Patchset 3 (id:??) landed as
https://crrev.com/e766bb6aa8822559c883690afe01b2bc7c1214d9
Cr-Commit-Position: refs/heads/master@{#374943}