Enable WebUSB through the Experimental Framework.

Enable WebUSB through the Experimental Framework.

Adds the APIExperimentEnabled annotation to all of WebUSB's IDL
interfaces. If the Experimental Framework is not enabled (or the
experiment key check fails) this API can still be enabled using the
--experimental-web-platform-features flag.

The USB interface is now always added to the local frame and WebUSB
notifications are enabled for all users (as the assumption is that only
sites with an EF key will actually be producing devices with the
necessary descriptors).

BUG=492204
Committed: https://crrev.com/5c00cb62536b679d52c3741598d3f08f79e7e32f
Cr-Commit-Position: refs/heads/master@{#386201}

[Reilly Grant (use Gerrit), 2016-02-08 19:27:19]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2016-03-24 00:30:08]

Patchset #1 (id:20001) has been deleted

[Reilly Grant (use Gerrit), 2016-04-07 02:18:31]

reillyg@chromium.org changed reviewers:
+ haraken@chromium.org, thestig@chromium.org

[Reilly Grant (use Gerrit), 2016-04-07 02:18:31]

thestig@, please review changes in //chrome/browser.
haraken@, please review changes in //third_party/WebKit.

After review this change will not be landed until an "Intent to Experiment" is
sent to blink-dev.

[Reilly Grant (use Gerrit), 2016-04-07 02:18:45]

Patchset #1 (id:40001) has been deleted

[Reilly Grant (use Gerrit), 2016-04-07 02:18:50]

Patchset #1 (id:60001) has been deleted

[haraken, 2016-04-07 02:21:58]

haraken@chromium.org changed reviewers:
+ chasej@chromium.org, iclelland@chromium.org

[haraken, 2016-04-07 02:21:58]

Maybe would it be better to wait for https://codereview.chromium.org/1861433002/
to land?

+chasej +iclelland

[iclelland, 2016-04-07 13:18:29]

On 2016/04/07 02:21:58, haraken wrote:
> Maybe would it be better to wait for
https://codereview.chromium.org/1861433002/
> to land?
> 
> +chasej +iclelland

The same issue exists in https://codereview.chromium.org/1858293002/ for
WebBluetooth. I'm fine working out the rebase conflicts in either order.

[haraken, 2016-04-07 13:43:10]

On 2016/04/07 13:18:29, iclelland wrote:
> On 2016/04/07 02:21:58, haraken wrote:
> > Maybe would it be better to wait for
> https://codereview.chromium.org/1861433002/
> > to land?
> > 
> > +chasej +iclelland
> 
> The same issue exists in https://codereview.chromium.org/1858293002/ for
> WebBluetooth. I'm fine working out the rebase conflicts in either order.

Stamping LGTM. It's up to you in which order you land the CLs :)

[Reilly Grant (use Gerrit), 2016-04-07 21:59:40]

reillyg@chromium.org changed reviewers:
+ dglazkov@chromium.org

[Reilly Grant (use Gerrit), 2016-04-07 21:59:41]

dglazkov@ for API OWNERS review.

[Reilly Grant (use Gerrit), 2016-04-07 22:10:55]

Patchset #2 (id:100001) has been deleted

[dglazkov, 2016-04-07 22:22:03]

lgtm

[Reilly Grant (use Gerrit), 2016-04-07 23:02:06]

reillyg@chromium.org changed reviewers:
+ esprehn@chromium.org

[Reilly Grant (use Gerrit), 2016-04-07 23:02:07]

esprehn@, please review //content/renderer/render_frame_impl.cc.

[Lei Zhang, 2016-04-07 23:07:36]

chrome/ lgtm

[esprehn, 2016-04-08 17:31:31]

lgtm

[Reilly Grant (use Gerrit), 2016-04-08 17:33:14]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-08 17:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1671553004/#ps120001
(title: "Update global interface expectations.")

[commit-bot: I haz the power, 2016-04-08 17:33:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671553004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671553004/120001

[chasej, 2016-04-08 18:02:59]

On 2016/04/08 17:33:47, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1671553004/120001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1671553004/120001

The compiles are failing, now that https://codereview.chromium.org/1861433002/
has landed to make the [RuntimeEnabled] and [OriginTrialEnabled] attributes
mutually exclusive.

I've created a CL (https://codereview.chromium.org/1866403004/) that corrects
the usage of [OriginTrialEnabled]. Hope that helps.

[Reilly Grant (use Gerrit), 2016-04-08 18:05:14]

On 2016/04/08 at 18:02:59, chasej wrote:
> On 2016/04/08 17:33:47, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1671553004/120001
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1671553004/120001
> 
> The compiles are failing, now that https://codereview.chromium.org/1861433002/
has landed to make the [RuntimeEnabled] and [OriginTrialEnabled] attributes
mutually exclusive.
> 
> I've created a CL (https://codereview.chromium.org/1866403004/) that corrects
the usage of [OriginTrialEnabled]. Hope that helps.

Thanks.

[commit-bot: I haz the power, 2016-04-08 18:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 18:07:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2016-04-08 20:05:22]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-08 20:05:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dglazkov@chromium.org, thestig@chromium.org, esprehn@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1671553004/#ps140001
(title: "Remove RuntimeEnabled=WebUSB.")

[commit-bot: I haz the power, 2016-04-08 20:05:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671553004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671553004/140001

[commit-bot: I haz the power, 2016-04-08 21:13:26]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-04-08 21:14:52]

Description was changed from

==========
Enable WebUSB through the Experimental Framework.

Adds the APIExperimentEnabled annotation to all of WebUSB's IDL
interfaces. If the Experimental Framework is not enabled (or the
experiment key check fails) this API can still be enabled using the
--experimental-web-platform-features flag.

The USB interface is now always added to the local frame and WebUSB
notifications are enabled for all users (as the assumption is that only
sites with an EF key will actually be producing devices with the
necessary descriptors).

BUG=492204
==========

to

==========
Enable WebUSB through the Experimental Framework.

Adds the APIExperimentEnabled annotation to all of WebUSB's IDL
interfaces. If the Experimental Framework is not enabled (or the
experiment key check fails) this API can still be enabled using the
--experimental-web-platform-features flag.

The USB interface is now always added to the local frame and WebUSB
notifications are enabled for all users (as the assumption is that only
sites with an EF key will actually be producing devices with the
necessary descriptors).

BUG=492204

Committed: https://crrev.com/5c00cb62536b679d52c3741598d3f08f79e7e32f
Cr-Commit-Position: refs/heads/master@{#386201}
==========

[commit-bot: I haz the power, 2016-04-08 21:14:53]

Patchset 3 (id:??) landed as
https://crrev.com/5c00cb62536b679d52c3741598d3f08f79e7e32f
Cr-Commit-Position: refs/heads/master@{#386201}