Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1866403004: WIP Enable WebUSB through the Experimental Framework. (Closed)

Created:
4 years, 8 months ago by chasej
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, haraken, blink-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebUSB through the Experimental Framework. Adds the APIExperimentEnabled annotation to all of WebUSB's IDL interfaces. If the Experimental Framework is not enabled (or the experiment key check fails) this API can still be enabled using the --experimental-web-platform-features flag. The USB interface is now always added to the local frame and WebUSB notifications are enabled for all users (as the assumption is that only sites with an EF key will actually be producing devices with the necessary descriptors). BUG=492204 patch from issue 1671553004 at patchset 120001 (http://crrev.com/1671553004#ps120001)

Patch Set 1 #

Patch Set 2 : Fix usage of [OriginTrialEnabled] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -30 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBAlternateInterface.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConfiguration.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConnectionEvent.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBEndpoint.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInTransferResult.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferPacket.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferResult.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBOutTransferResult.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
chasej
4 years, 8 months ago (2016-04-08 16:51:48 UTC) #1 
Description was changed from

==========
Enable WebUSB through the Experimental Framework.

Adds the APIExperimentEnabled annotation to all of WebUSB's IDL
interfaces. If the Experimental Framework is not enabled (or the
experiment key check fails) this API can still be enabled using the
--experimental-web-platform-features flag.

The USB interface is now always added to the local frame and WebUSB
notifications are enabled for all users (as the assumption is that only
sites with an EF key will actually be producing devices with the
necessary descriptors).

BUG=492204

patch from issue 1671553004 at patchset 120001
(http://crrev.com/1671553004#ps120001)
==========

to

==========
Enable WebUSB through the Experimental Framework.

Adds the APIExperimentEnabled annotation to all of WebUSB's IDL
interfaces. If the Experimental Framework is not enabled (or the
experiment key check fails) this API can still be enabled using the
--experimental-web-platform-features flag.

The USB interface is now always added to the local frame and WebUSB
notifications are enabled for all users (as the assumption is that only
sites with an EF key will actually be producing devices with the
necessary descriptors).

BUG=492204

patch from issue 1671553004 at patchset 120001
(http://crrev.com/1671553004#ps120001)
==========

Powered by Google App Engine
This is Rietveld 408576698