Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1858293002: bluetooth: Enable Web Bluetooth on experimental framework (Closed)

Created:
4 years, 8 months ago by ortuno
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, kinuko+watch, nasko+codewatch_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Enable Web Bluetooth on experimental framework This enables Web Bluetooth through experimental frameworks in supported platforms. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8 Adds the OriginTrialEnabled extended binding so that the bindings are visible to domains that have valid EF tokens. Also adds WebBluetooth to frames and BluetoothDispatcherHost to processes' filters for supported platforms. TEST=Manual testing required: Launch chrome and perform the following tests: On a Chrome OS device and an Android device: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html 2. Press the "Run Test" button. 3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should be "Bluetooth Works". 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html 2. Press the "Run Test" button. 3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should be "Bluetooth Unavailable". On a Linux, OSX and Windows devices: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html 2. Press the "Run Test" button. 3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should be "Bluetooth blocked". 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html 2. Press the "Run Test" button. 3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should be "Bluetooth Unavailable". Launch Chrome with the following command line flag: --enable-web-bluetooth On a Chrome OS, Android, Linux, OSX, and Windows devices: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html 2. Press the "Run Test" button. 3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should be "Bluetooth Works". On a Chrome OS, Android, Linux, OSX, and Windows devices: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html 2. Press the "Run Test" button. 3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should be "Bluetooth Works". BUG=584113 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a49836d0f1f94dc869ea8005fea24f8916d58869 Cr-Commit-Position: refs/heads/master@{#385814}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 3 chunks +9 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
ortuno
jyasskin: PTAL
4 years, 8 months ago (2016-04-05 16:58:30 UTC) #6
Jeffrey Yasskin
lgtm https://codereview.chromium.org/1858293002/diff/1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt File third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt (right): https://codereview.chromium.org/1858293002/diff/1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt#newcode13 third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:13: CONSOLE ERROR: The 'WebBluetooth' feature is currently enabled ...
4 years, 8 months ago (2016-04-05 17:22:52 UTC) #7
ortuno
Thanks!
4 years, 8 months ago (2016-04-05 17:24:02 UTC) #8
ortuno
PTAL for EF. Also jyasskin's asks if there is a issue for replacing [Phosphor console ...
4 years, 8 months ago (2016-04-05 17:25:16 UTC) #10
iclelland
EF integration LGTM https://codereview.chromium.org/1858293002/diff/1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt File third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt (right): https://codereview.chromium.org/1858293002/diff/1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt#newcode13 third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:13: CONSOLE ERROR: The 'WebBluetooth' feature is ...
4 years, 8 months ago (2016-04-06 13:56:50 UTC) #11
ortuno
haraken: PTAL at third_party/WebKit dglazkov: PTAL at third_party/WebKit/LayoutTests/virtual/stable/webexposed/ jam: PTAL at content/
4 years, 8 months ago (2016-04-06 15:21:03 UTC) #13
jam
lgtm
4 years, 8 months ago (2016-04-06 17:16:01 UTC) #14
haraken
modules/ LGTM
4 years, 8 months ago (2016-04-06 23:41:29 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858293002/1
4 years, 8 months ago (2016-04-07 15:07:28 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 17:46:13 UTC) #19
dglazkov
lgtm
4 years, 8 months ago (2016-04-07 18:16:55 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858293002/1
4 years, 8 months ago (2016-04-07 18:19:20 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 18:26:58 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 18:28:28 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a49836d0f1f94dc869ea8005fea24f8916d58869
Cr-Commit-Position: refs/heads/master@{#385814}

Powered by Google App Engine
This is Rietveld 408576698