Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6914)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index ebb80b5db1a4bc64d617ef1436f7a4918cffe8fc..c33643e0a54ac787cb0ddd1dab66f25134e2a234 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -448,7 +448,8 @@ TEST(CommandsTest, SuccessfulFindElement) {
params.SetString("value", "a");
std::unique_ptr<base::Value> result;
ASSERT_EQ(kOk,
- ExecuteFindElement(1, &session, &web_view, params, &result).code());
+ ExecuteFindElement(1, &session, &web_view, params, &result,
+ nullptr).code());
base::DictionaryValue param;
param.SetString("id", "a");
base::ListValue expected_args;
@@ -464,7 +465,8 @@ TEST(CommandsTest, FailedFindElement) {
params.SetString("value", "a");
std::unique_ptr<base::Value> result;
ASSERT_EQ(kNoSuchElement,
- ExecuteFindElement(1, &session, &web_view, params, &result).code());
+ ExecuteFindElement(1, &session, &web_view, params, &result,
+ nullptr).code());
}
TEST(CommandsTest, SuccessfulFindElements) {
@@ -476,9 +478,9 @@ TEST(CommandsTest, SuccessfulFindElements) {
params.SetString("using", "name");
params.SetString("value", "b");
std::unique_ptr<base::Value> result;
- ASSERT_EQ(
- kOk,
- ExecuteFindElements(1, &session, &web_view, params, &result).code());
+ ASSERT_EQ(kOk,
+ ExecuteFindElements(1, &session, &web_view, params, &result,
+ nullptr).code());
base::DictionaryValue param;
param.SetString("name", "b");
base::ListValue expected_args;
@@ -493,9 +495,9 @@ TEST(CommandsTest, FailedFindElements) {
params.SetString("using", "id");
params.SetString("value", "a");
std::unique_ptr<base::Value> result;
- ASSERT_EQ(
- kOk,
- ExecuteFindElements(1, &session, &web_view, params, &result).code());
+ ASSERT_EQ(kOk,
+ ExecuteFindElements(1, &session, &web_view, params, &result,
+ nullptr).code());
base::ListValue* list;
ASSERT_TRUE(result->GetAsList(&list));
ASSERT_EQ(0U, list->GetSize());
@@ -590,7 +592,8 @@ TEST(CommandsTest, TimeoutInFindElement) {
params.SetString("id", "1");
std::unique_ptr<base::Value> result;
ASSERT_EQ(kNoSuchElement,
- ExecuteFindElement(1, &session, &web_view, params, &result).code());
+ ExecuteFindElement(1, &session, &web_view, params, &result,
+ nullptr).code());
}
namespace {
@@ -623,9 +626,11 @@ TEST(CommandsTest, ErrorFindElement) {
params.SetString("value", "a");
std::unique_ptr<base::Value> value;
ASSERT_EQ(kUnknownError,
- ExecuteFindElement(1, &session, &web_view, params, &value).code());
+ ExecuteFindElement(1, &session, &web_view, params, &value,
+ nullptr).code());
ASSERT_EQ(kUnknownError,
- ExecuteFindElements(1, &session, &web_view, params, &value).code());
+ ExecuteFindElements(1, &session, &web_view, params, &value,
+ nullptr).code());
}
TEST(CommandsTest, ErrorFindChildElement) {
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl_unittest.cc ('k') | chrome/test/chromedriver/element_commands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698