Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8137)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl_unittest.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.cc ('k') | chrome/test/chromedriver/commands_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc b/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
index 755f655447dd022dbf57451a5e790e591a3058f7..179a8bb3f1d8f349ca4d24e4fdfc9385001043fd 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
@@ -36,12 +36,18 @@ class FakeDevToolsClient : public DevToolsClient {
Status SendCommand(
const std::string& method,
const base::DictionaryValue& params) override {
- return SendCommandAndGetResult(method, params, NULL);
+ return SendCommandAndGetResult(method, params, nullptr);
+ }
+ Status SendCommandWithTimeout(
+ const std::string& method,
+ const base::DictionaryValue& params,
+ const Timeout* timeout) override {
+ return SendCommandAndGetResult(method, params, nullptr);
}
Status SendAsyncCommand(
const std::string& method,
const base::DictionaryValue& params) override {
- return SendCommandAndGetResult(method, params, NULL);
+ return SendCommandAndGetResult(method, params, nullptr);
}
Status SendCommandAndGetResult(
const std::string& method,
@@ -52,9 +58,16 @@ class FakeDevToolsClient : public DevToolsClient {
result->reset(result_.DeepCopy());
return Status(kOk);
}
+ Status SendCommandAndGetResultWithTimeout(
+ const std::string& method,
+ const base::DictionaryValue& params,
+ const Timeout* timeout,
+ std::unique_ptr<base::DictionaryValue>* result) override {
+ return SendCommandAndGetResult(method, params, result);
+ }
void AddListener(DevToolsEventListener* listener) override {}
Status HandleEventsUntil(const ConditionalFunc& conditional_func,
- const base::TimeDelta& timeout) override {
+ const Timeout& timeout) override {
return Status(kOk);
}
Status HandleReceivedEvents() override { return Status(kOk); }
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.cc ('k') | chrome/test/chromedriver/commands_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698