Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/test/chromedriver/element_commands.h

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/element_commands.h
diff --git a/chrome/test/chromedriver/element_commands.h b/chrome/test/chromedriver/element_commands.h
index 6fd7184b882592822d1d7e28786c28d656fd4d7f..320c3eea50f0c14fabd1e52d4e33ed1d93a4853a 100644
--- a/chrome/test/chromedriver/element_commands.h
+++ b/chrome/test/chromedriver/element_commands.h
@@ -17,6 +17,7 @@ class Value;
struct Session;
class Status;
+class Timeout;
class WebView;
typedef base::Callback<Status(Session* session,
@@ -27,11 +28,13 @@ typedef base::Callback<Status(Session* session,
ElementCommand;
// Execute a command on a specific element.
-Status ExecuteElementCommand(const ElementCommand& command,
- Session* session,
- WebView* web_view,
- const base::DictionaryValue& params,
- std::unique_ptr<base::Value>* value);
+Status ExecuteElementCommand(
+ const ElementCommand& command,
+ Session* session,
+ WebView* web_view,
+ const base::DictionaryValue& params,
+ std::unique_ptr<base::Value>* value,
+ Timeout* timeout);
// Search for an element on the page, starting from the given element.
Status ExecuteFindChildElement(int interval_ms,
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698