Issue 1669043002: Implement attribute getters for IntersectionObserver.

Issue 1669043002: Implement attribute getters for IntersectionObserver. (Closed)

Created:
4 years, 10 months ago by szager1

Modified:
4 years, 10 months ago

Reviewers:
esprehn, ojan

CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
https://chromium.googlesource.com/chromium/src@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Implement attribute getters for IntersectionObserver. BUG=540528 R=ojan@chromium.org,esprehn@chromium.org Committed: https://crrev.com/6d28dc728375473c3f0bde8ccbae36ee493a812b Cr-Commit-Position: refs/heads/master@{#373775}

Patch Set 1 #

Patch Set 2 : Fix test expectation #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -15 lines)			Patch
A	third_party/WebKit/LayoutTests/intersection-observer/observer-attributes.html	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/intersection-observer/observer-attributes-expected.txt	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/IntersectionObservation.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/dom/IntersectionObserver.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/dom/IntersectionObserver.cpp	View		4 chunks	+42 lines, -12 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/IntersectionObserver.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 12 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669043002/1

4 years, 10 months ago (2016-02-05 01:07:11 UTC) #4

commit-bot: I haz the power

Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/169611)

4 years, 10 months ago (2016-02-05 02:15:23 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669043002/20001

4 years, 10 months ago (2016-02-05 06:34:09 UTC) #9

commit-bot: I haz the power

4 years, 10 months ago (2016-02-05 09:19:01 UTC) #12

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/6d28dc728375473c3f0bde8ccbae36ee493a812b
Cr-Commit-Position: refs/heads/master@{#373775}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages