third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp - Issue 1669043002: Implement attribute getters for IntersectionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

Issue 1669043002: Implement attribute getters for IntersectionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix test expectation Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

index 54b4c177b4277abb98f7e6efa50204a55644e337..15cfa0c58d3abf30b990eb31af2990fcf99f6554 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp

@@ -77,7 +77,7 @@ void IntersectionObserverController::removeTrackedObserversForRoot(const Node& r

{

HeapVector<Member<IntersectionObserver>> toRemove;

for (auto& observer : m_trackedIntersectionObservers) {

- if (observer->root() == &root)

+ if (observer->rootNode() == &root)

toRemove.append(observer);

}

m_trackedIntersectionObservers.removeAll(toRemove);

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserver.idl ('k') | no next file » | no next file with comments »