third_party/WebKit/Source/core/dom/IntersectionObserver.h - Issue 1669043002: Implement attribute getters for IntersectionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.h

Issue 1669043002: Implement attribute getters for IntersectionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix test expectation Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

index ae8eccaed290c150e54a51c6fd8f0e2a381737ac..067dba5257faec88e2bf47741c233d00529fe4fe 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

@@ -32,8 +32,11 @@ public:

void observe(Element*, ExceptionState&);

void unobserve(Element*, ExceptionState&);

HeapVector<Member<IntersectionObserverEntry>> takeRecords();

+ Element* root() const;

+ String rootMargin() const;

+ const Vector<float>& thresholds() const { return m_thresholds; }

- Node* root() const { return m_root.get(); }

+ Node* rootNode() const { return m_root.get(); }

LayoutObject* rootLayoutObject() const;

bool hasPercentMargin() const;

const Length& topMargin() const { return m_topMargin; }