src/runtime/runtime-object.cc - Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressing nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index d5e57562551a8944b11cc613909bd349c03ac9be..1f7b44770a7c74103bedc70a6466e7361d81c8e7 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -723,8 +723,8 @@ RUNTIME_FUNCTION(Runtime_GetOwnPropertyKeys) {

Handle<FixedArray> keys;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

- isolate, keys, JSReceiver::GetKeys(object, JSReceiver::OWN_ONLY, filter,

- CONVERT_TO_STRING));

+ isolate, keys,

+ JSReceiver::GetKeys(object, OWN_ONLY, filter, CONVERT_TO_STRING));

return *isolate->factory()->NewJSArrayWithElements(keys);

}

« no previous file with comments | « src/runtime/runtime-forin.cc ('k') | test/mjsunit/harmony/proxies-ownkeys.js » ('j') | no next file with comments »