src/runtime/runtime-forin.cc - Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-forin.cc

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressing nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-forin.cc

diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc

index 57a05f6f3b6a84d48bf0c9cd38d470c54ede9e57..c44945c94ce64141006ee7293b30b4ceb068606a 100644

--- a/src/runtime/runtime-forin.cc

+++ b/src/runtime/runtime-forin.cc

@@ -24,8 +24,8 @@ MaybeHandle<HeapObject> Enumerate(Handle<JSReceiver> receiver) {

if (!receiver->IsSimpleEnum()) {

Handle<FixedArray> keys;

ASSIGN_RETURN_ON_EXCEPTION(

- isolate, keys, JSReceiver::GetKeys(receiver, JSReceiver::INCLUDE_PROTOS,

- ENUMERABLE_STRINGS),

+ isolate, keys,

+ JSReceiver::GetKeys(receiver, INCLUDE_PROTOS, ENUMERABLE_STRINGS),

HeapObject);

// Test again, since cache may have been built by GetKeys() calls above.

if (!receiver->IsSimpleEnum()) return keys;

« no previous file with comments | « src/runtime/runtime-array.cc ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »