Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/runtime/runtime-object.cc

Issue 1668853002: [proxies] allow duplicate keys for [[OwnPropertyKeys]] trap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressing nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-forin.cc ('k') | test/mjsunit/harmony/proxies-ownkeys.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
716 716
717 RUNTIME_FUNCTION(Runtime_GetOwnPropertyKeys) { 717 RUNTIME_FUNCTION(Runtime_GetOwnPropertyKeys) {
718 HandleScope scope(isolate); 718 HandleScope scope(isolate);
719 DCHECK(args.length() == 2); 719 DCHECK(args.length() == 2);
720 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0); 720 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0);
721 CONVERT_SMI_ARG_CHECKED(filter_value, 1); 721 CONVERT_SMI_ARG_CHECKED(filter_value, 1);
722 PropertyFilter filter = static_cast<PropertyFilter>(filter_value); 722 PropertyFilter filter = static_cast<PropertyFilter>(filter_value);
723 723
724 Handle<FixedArray> keys; 724 Handle<FixedArray> keys;
725 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 725 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
726 isolate, keys, JSReceiver::GetKeys(object, JSReceiver::OWN_ONLY, filter, 726 isolate, keys,
727 CONVERT_TO_STRING)); 727 JSReceiver::GetKeys(object, OWN_ONLY, filter, CONVERT_TO_STRING));
728 728
729 return *isolate->factory()->NewJSArrayWithElements(keys); 729 return *isolate->factory()->NewJSArrayWithElements(keys);
730 } 730 }
731 731
732 732
733 // Return information on whether an object has a named or indexed interceptor. 733 // Return information on whether an object has a named or indexed interceptor.
734 // args[0]: object 734 // args[0]: object
735 RUNTIME_FUNCTION(Runtime_GetInterceptorInfo) { 735 RUNTIME_FUNCTION(Runtime_GetInterceptorInfo) {
736 HandleScope scope(isolate); 736 HandleScope scope(isolate);
737 DCHECK(args.length() == 1); 737 DCHECK(args.length() == 1);
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
1288 DCHECK(args.length() == 2); 1288 DCHECK(args.length() == 2);
1289 CONVERT_ARG_HANDLE_CHECKED(Object, o, 0); 1289 CONVERT_ARG_HANDLE_CHECKED(Object, o, 0);
1290 CONVERT_ARG_HANDLE_CHECKED(Object, properties, 1); 1290 CONVERT_ARG_HANDLE_CHECKED(Object, properties, 1);
1291 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 1291 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
1292 isolate, o, JSReceiver::DefineProperties(isolate, o, properties)); 1292 isolate, o, JSReceiver::DefineProperties(isolate, o, properties));
1293 return *o; 1293 return *o;
1294 } 1294 }
1295 1295
1296 } // namespace internal 1296 } // namespace internal
1297 } // namespace v8 1297 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-forin.cc ('k') | test/mjsunit/harmony/proxies-ownkeys.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698