components/password_manager/core/common/password_manager_features.h - Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/password_manager_features.h

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses the review inputs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager_test_utils.cc ('K') | « components/password_manager/core/common/BUILD.gn ('k') | components/password_manager/core/common/password_manager_features.cc » ('j') | components/password_manager/core/common/password_manager_features.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/password_manager_features.h

diff --git a/components/password_manager/core/common/password_manager_features.h b/components/password_manager/core/common/password_manager_features.h

index 32cfcb82683aad4a4c5edc8750a097ae8c1805ff..4dfb4f001a5ba3099767805d63b6b474106a5c18 100644

--- a/components/password_manager/core/common/password_manager_features.h

+++ b/components/password_manager/core/common/password_manager_features.h

@@ -17,10 +17,17 @@ namespace features {

// All features in alphabetical order. The features should be documented

// alongside the definition of their values in the .cc file.

+extern const base::Feature kAffiliationBasedMatching;

+extern const base::Feature kDropSyncCredential;

extern const base::Feature kEnableAutomaticPasswordSaving;

+extern const base::Feature kEnableDropSyncCredential;

+extern const base::Feature kEnableManagerForSyncSignin;

extern const base::Feature kEnableManualPasswordGeneration;

extern const base::Feature kEnablePasswordChangeSupport;

extern const base::Feature kEnablePasswordForceSaving;

+extern const base::Feature kManagerForSyncSignin;

+extern const base::Feature kProtectSyncCredential;

+extern const base::Feature kProtectSyncCredentialOnReauth;

} // namespace features