[Password Manager] Switch password manager code to use the Feature framework.

components/password_manager/core/common/password_manager_features.cc

Index: components/password_manager/core/common/password_manager_features.cc
diff --git a/components/password_manager/core/common/password_manager_features.cc b/components/password_manager/core/common/password_manager_features.cc
index c1f9f4d9ca88cbe09a023a73293ff47dadb258a3..702cd34d5537313877b9356bc5a86dd88b68b3b1 100644
--- a/components/password_manager/core/common/password_manager_features.cc
+++ b/components/password_manager/core/common/password_manager_features.cc
@@ -8,11 +8,30 @@ namespace password_manager {
 
 namespace features {
 
+// Enable affiliation based matching, so that credentials stored for an Android
+// application will also be considered matches for, and be filled into
+// corresponding Web applications.
+const base::Feature kAffiliationBasedMatching = {
+    "affiliation-based-matching", base::FEATURE_DISABLED_BY_DEFAULT};
+
+// Enables dropping the credential used to sync passwords.

[vabr (Chromium), 2016/02/11 12:30:21]

nit: Reformulate for clarity:
// Drop the sync credential if captured for saving, do not offer it for saving.

[Pritam Nikam, 2016/02/25 14:16:06]

Done.

+const base::Feature kDropSyncCredential = {"drop-sync-credential",
+                                           base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Disables the save-password prompt. Passwords are then saved automatically,
 // without asking the user.
 const base::Feature kEnableAutomaticPasswordSaving = {
     "enable-automatic-password-saving", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Enable dropping the credential used to sync passwords.
+const base::Feature kEnableDropSyncCredential = {
+    "enable-drop-sync-credential", base::FEATURE_DISABLED_BY_DEFAULT};

[Bernhard Bauer, 2016/02/11 11:12:40]

These two features are unused and redundant.

[Pritam Nikam, 2016/02/25 14:16:06]

Done.

+
+// Enable saving and filling for the sync signin form. Currently the default
+// behavior.
+const base::Feature kEnableManagerForSyncSignin = {
+    "enable-manager-for-sync-signin", base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Enable supporting of updating password in the password manager on a password
 // change form submit.
 const base::Feature kEnablePasswordChangeSupport = {
@@ -27,6 +46,19 @@ const base::Feature kEnablePasswordForceSaving = {
 extern const base::Feature kEnableManualPasswordGeneration = {
     "enable-manual-password-generation", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Enables saving and filling for the sync signin form.
+const base::Feature kManagerForSyncSignin = {"manager-for-sync-signin",

[vabr (Chromium), 2016/02/11 12:30:21]

This one is actually obsolete and ready for removal: http://crbug.com/586107.

However, that removal should be done in a separate CL.

[Pritam Nikam, 2016/02/25 14:16:06]

Acknowledged.

+                                             base::FEATURE_DISABLED_BY_DEFAULT};
+
+// Disallow autofilling of the sync credential.
+const base::Feature kProtectSyncCredential = {
+    "protect-sync-credential", base::FEATURE_DISABLED_BY_DEFAULT};
+
+// Disallow autofilling of the sync credential only for transactional reauth
+// pages.
+const base::Feature kProtectSyncCredentialOnReauth = {
+    "protect-sync-credential-on-reauth", base::FEATURE_DISABLED_BY_DEFAULT};
+
 }  // namespace features
 
 }  // namespace password_manager