Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: components/password_manager/core/browser/password_manager_test_utils.cc

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses the review inputs. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_test_utils.cc
diff --git a/components/password_manager/core/browser/password_manager_test_utils.cc b/components/password_manager/core/browser/password_manager_test_utils.cc
index 170be56505156412d43fec90ad7b9cc53c2cdcb0..9361407dbd041b6bc54b02971ac70c4c7be74ed0 100644
--- a/components/password_manager/core/browser/password_manager_test_utils.cc
+++ b/components/password_manager/core/browser/password_manager_test_utils.cc
@@ -8,6 +8,7 @@
#include <ostream>
#include <string>
+#include "base/feature_list.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -95,6 +96,29 @@ bool ContainsEqualPasswordFormsUnordered(
return !had_mismatched_actual_form && remaining_expectations.empty();
}
+void EnableFeature(const base::Feature& feature,
+ bool set_enabled,
+ bool appends_to_list) {
+ std::string enable_overrides, disable_overrides;
Bernhard Bauer 2016/02/11 11:12:40 Nit: Declare each variable on a separate line.
Pritam Nikam 2016/02/25 14:16:06 Done.
+ if (appends_to_list) {
+ base::FeatureList::GetInstance()->GetFeatureOverrides(&enable_overrides,
+ &disable_overrides);
+ }
+
+ if (set_enabled) {
+ enable_overrides.push_back(',');
+ enable_overrides.append(feature.name);
+ } else {
+ disable_overrides.push_back(',');
+ disable_overrides.append(feature.name);
+ }
+
+ base::FeatureList::ClearInstanceForTesting();
+ scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
+ feature_list->InitializeFromCommandLine(enable_overrides, disable_overrides);
+ base::FeatureList::SetInstance(std::move(feature_list));
+}
+
MockPasswordStoreObserver::MockPasswordStoreObserver() {}
MockPasswordStoreObserver::~MockPasswordStoreObserver() {}

Powered by Google App Engine
This is Rietveld 408576698