components/password_manager/core/browser/password_manager_util.cc - Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_util.cc

Issue 1668523002: [Password Manager] Switch password manager code to use the Feature framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses the review inputs. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager_test_utils.cc ('K') | « components/password_manager/core/browser/password_manager_util.h ('k') | components/password_manager/core/browser/password_store_factory_util.cc » ('j') | components/password_manager/core/common/password_manager_features.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_util.cc

diff --git a/components/password_manager/core/browser/password_manager_util.cc b/components/password_manager/core/browser/password_manager_util.cc

index c4ccce1ecf9632625544c58a052e9ee568ec14bd..659d8edd7b910bed11a660ed65ef75aac270f167 100644

--- a/components/password_manager/core/browser/password_manager_util.cc

+++ b/components/password_manager/core/browser/password_manager_util.cc

@@ -91,4 +91,9 @@ bool IsLoggingActive(const password_manager::PasswordManagerClient* client) {

return log_manager && log_manager->IsLoggingActive();

}

+bool IsFeatureDisabledFromCommandLine(const base::Feature& feature) {

+ return base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(

+ feature.name, base::FeatureList::OVERRIDE_DISABLE_FEATURE);

} // namespace password_manager_util