Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1667733002: Move chrome_browser_state.{cc,h} to ios/chrome/browser/browser_state. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
droger
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, grt+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, markusheintz_, maxbogue+watch_chromium.org, melevin+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, msramek+watch_chromium.org, noyau+watch_chromium.org, plaree+watch_chromium.org, raymes+watch_chromium.org, rouslan+autofill_chromium.org, samarth+watch_chromium.org, sdefresne+watch_chromium.org, skanuj+watch_chromium.org, James Su, tfarina, tim+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_support_ios
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chrome_browser_state.{cc,h} to ios/chrome/browser/browser_state. In preparation of upstreaming the implementation of ChromeBrowserState, move the code to ios/chrome/browser/browser_state. Leave a forwarding header to avoid breaking downstream at next merge. BUG=None Committed: https://crrev.com/ad20c4eb6b6a1cf095f7af93a3bddb16adf1f54b Cr-Commit-Position: refs/heads/master@{#373249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -269 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_classifier_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/shortcuts_backend_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/personal_data_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/bookmarks/bookmark_model_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/bookmarks/bookmarks_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/bookmarks/startup_task_runner_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/browser_state_otr_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/browser_state/chrome_browser_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/browser_state/chrome_browser_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/content_settings/cookie_settings_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/content_settings/host_content_settings_map_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/data_reduction_proxy/ios_chrome_data_reduction_proxy_settings_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/dom_distiller/distiller_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/favicon/favicon_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/google/google_url_tracker_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/google/google_url_tracker_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/history/history_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/history/top_sites_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/history/web_history_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/interstitials/ios_chrome_controller_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/interstitials/ios_chrome_metrics_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/interstitials/ios_security_interstitial_page.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/net/cookie_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/password_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/rlz/rlz_tracker_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/search/search_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/search_engines/template_url_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/services/gcm/ios_chrome_gcm_profile_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_tab_restore_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/about_signin_internals_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/account_consistency_service_factory.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/account_fetcher_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/account_reconcilor_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/account_tracker_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/browser_state_data_remover.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/fake_oauth2_token_service_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/fake_signin_manager_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/gaia_cookie_manager_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/ios_chrome_signin_status_metrics_provider_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/oauth2_token_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_client_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_error_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/suggestions/suggestions_service_factory.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/fake_sync_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/glue/sync_start_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/sync_setup_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/chrome_ios_translate_client.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/translate_accept_languages_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/about_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/flags_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/gcm/gcm_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/history_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/net_export/net_export_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/undo/bookmark_undo_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web_data_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/provider/ios_provider_chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/public/provider/chrome/browser/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/browser_state/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/browser_state/chrome_browser_state.h View 1 chunk +5 lines, -138 lines 0 comments Download
D ios/public/provider/chrome/browser/browser_state/chrome_browser_state.cc View 1 chunk +0 lines, -36 lines 0 comments Download

Depends on Patchset:

Issue 1663783002 Patch 20001

Dependent Patchsets:

Issue 1667743002 Patch 1

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 10 months ago (2016-02-03 13:48:47 UTC) #2
droger
lgtm
4 years, 10 months ago (2016-02-03 14:03:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667733002/1
4 years, 10 months ago (2016-02-03 15:42:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 16:11:15 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 16:12:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ad20c4eb6b6a1cf095f7af93a3bddb16adf1f54b
Cr-Commit-Position: refs/heads/master@{#373249}

Powered by Google App Engine
This is Rietveld 408576698