Implement some methods of ChromeBrowserState.

Implement some methods of ChromeBrowserState.

Implement the methods shared between all ChromeBrowserState
sub-classes.

BUG=429756
Committed: https://crrev.com/761098fba97c6ec094e241b61ecf879134ab7922
Cr-Commit-Position: refs/heads/master@{#373256}

[sdefresne, 2016-02-03 14:47:25]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2016-02-03 14:47:26]

Please take a look.

[sdefresne, 2016-02-03 14:48:06]

Description was changed from

==========
Implememt some methods of ChromeBrowserState.

BUG=429756
==========

to

==========
Implement some methods of ChromeBrowserState.

Implement the methods shared between all ChromeBrowserState
sub-classes.

BUG=429756
==========

[sdefresne, 2016-02-03 14:48:06]

sdefresne@chromium.org changed reviewers:
- droger@chromium.org

[sdefresne, 2016-02-03 14:48:28]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2016-02-03 14:48:29]

Please do *not* send to CQ.

[droger, 2016-02-03 16:20:49]

lgtm

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/DEPS
File ios/chrome/browser/DEPS (right):

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/DEPS#new...
ios/chrome/browser/DEPS:84: "+ios/web/webui",
Could you file a bug to remove this dependency? And maybe add this dependency as
a file-specific rule only.

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/browser_...
File ios/chrome/browser/browser_state/chrome_browser_state.h (right):

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/browser_...
ios/chrome/browser/browser_state/chrome_browser_state.h:136: virtual
TestChromeBrowserState* AsTestChromeBrowserState();
It would be great to remove this:
1) It seems this method is only called in one place, and it is in code related
to the data proxy, which is now deprecated.
2) I don't think it's a good design to have this method

Could you maybe try to see if the tests pass if it is removed? And maybe file a
bug to remove it if it is not trivial.

[sdefresne, 2016-02-03 16:32:05]

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/DEPS
File ios/chrome/browser/DEPS (right):

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/DEPS#new...
ios/chrome/browser/DEPS:84: "+ios/web/webui",
On 2016/02/03 at 16:20:48, droger wrote:
> Could you file a bug to remove this dependency? And maybe add this dependency
as a file-specific rule only.

=> crbug.com/583685

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/browser_...
File ios/chrome/browser/browser_state/chrome_browser_state.h (right):

https://codereview.chromium.org/1667743002/diff/1/ios/chrome/browser/browser_...
ios/chrome/browser/browser_state/chrome_browser_state.h:136: virtual
TestChromeBrowserState* AsTestChromeBrowserState();
On 2016/02/03 at 16:20:48, droger wrote:
> It would be great to remove this:
> 1) It seems this method is only called in one place, and it is in code related
to the data proxy, which is now deprecated.
> 2) I don't think it's a good design to have this method
> 
> Could you maybe try to see if the tests pass if it is removed? And maybe file
a bug to remove it if it is not trivial.

=> crbug.com/583682

[sdefresne, 2016-02-03 16:48:27]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-02-03 16:48:28]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1667743002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-02-03 16:48:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667743002/20001

[commit-bot: I haz the power, 2016-02-03 16:53:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-03 16:55:30]

Description was changed from

==========
Implement some methods of ChromeBrowserState.

Implement the methods shared between all ChromeBrowserState
sub-classes.

BUG=429756
==========

to

==========
Implement some methods of ChromeBrowserState.

Implement the methods shared between all ChromeBrowserState
sub-classes.

BUG=429756

Committed: https://crrev.com/761098fba97c6ec094e241b61ecf879134ab7922
Cr-Commit-Position: refs/heads/master@{#373256}
==========

[commit-bot: I haz the power, 2016-02-03 16:55:31]

Patchset 2 (id:??) landed as
https://crrev.com/761098fba97c6ec094e241b61ecf879134ab7922
Cr-Commit-Position: refs/heads/master@{#373256}