Remove the //ios/public/test target.

Remove the //ios/public/test target.

Move the test implementation of //ios/public/provider interfaces
to //ios/chrome/browser and //ios/public/provider/chrome/browser
in preparation of moving chrome_browser_state.h.

Add a forwarding header to avoid breaking downstream once this CL
lands with the merge. It will be removed in a followup CL once all
the downstream code has been fixed to use the new header location.

Reformat the code with "git cl format ios/chrome".

BUG=437333
Committed: https://crrev.com/a2b657a54e8f37ad664957f40d7b385c990c89c4
Cr-Commit-Position: refs/heads/master@{#373238}

[sdefresne, 2016-02-03 12:57:07]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2016-02-03 12:57:08]

Please take a look.

[droger, 2016-02-03 13:25:31]

As discussed offline, I would prefer moving the files in
- ios/chrome/browser/provider
to
- ios/public/provider/chrome/browser

[sdefresne, 2016-02-03 13:41:48]

Description was changed from

==========
Remove the //ios/public/test target.

Move the test implementation of //ios/public/provider interfaces to
//ios/chrome/browser in preparation of moving chrome_browser_state.h
there too.

Add a forwarding header to avoid breaking downstream once this CL
lands with the merge. It will be removed in a followup CL once all
the downstream code has been fixed to use the new header location.

Reformat the code with "git cl format ios/chrome".

BUG=None
==========

to

==========
Remove the //ios/public/test target.

Move the test implementation of //ios/public/provider interfaces
to //ios/chrome/browser and //ios/public/provider/chrome/browser
in preparation of moving chrome_browser_state.h.

Add a forwarding header to avoid breaking downstream once this CL
lands with the merge. It will be removed in a followup CL once all
the downstream code has been fixed to use the new header location.

Reformat the code with "git cl format ios/chrome".

BUG=None
==========

[sdefresne, 2016-02-03 13:44:00]

On 2016/02/03 at 13:25:31, droger wrote:
> As discussed offline, I would prefer moving the files in
> - ios/chrome/browser/provider
> to
> - ios/public/provider/chrome/browser

Done, please take another look.

[droger, 2016-02-03 13:56:31]

Thank you.

LGTM

https://codereview.chromium.org/1663783002/diff/20001/ios/chrome/ios_chrome_t...
File ios/chrome/ios_chrome_tests.gyp (right):

https://codereview.chromium.org/1663783002/diff/20001/ios/chrome/ios_chrome_t...
ios/chrome/ios_chrome_tests.gyp:141: 'test/testing_application_context.h',
Not related to your CL, but (some of) these files in //ios/chrome/test may also
be in the wrong place.

[sdefresne, 2016-02-03 14:07:32]

Description was changed from

==========
Remove the //ios/public/test target.

Move the test implementation of //ios/public/provider interfaces
to //ios/chrome/browser and //ios/public/provider/chrome/browser
in preparation of moving chrome_browser_state.h.

Add a forwarding header to avoid breaking downstream once this CL
lands with the merge. It will be removed in a followup CL once all
the downstream code has been fixed to use the new header location.

Reformat the code with "git cl format ios/chrome".

BUG=None
==========

to

==========
Remove the //ios/public/test target.

Move the test implementation of //ios/public/provider interfaces
to //ios/chrome/browser and //ios/public/provider/chrome/browser
in preparation of moving chrome_browser_state.h.

Add a forwarding header to avoid breaking downstream once this CL
lands with the merge. It will be removed in a followup CL once all
the downstream code has been fixed to use the new header location.

Reformat the code with "git cl format ios/chrome".

BUG=437333
==========

[sdefresne, 2016-02-03 14:14:56]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-02-03 14:14:56]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1663783002/#ps40001
(title: "Add missing forwarding-header")

[commit-bot: I haz the power, 2016-02-03 14:15:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663783002/40001

[commit-bot: I haz the power, 2016-02-03 15:16:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-03 15:17:43]

Description was changed from

==========
Remove the //ios/public/test target.

Move the test implementation of //ios/public/provider interfaces
to //ios/chrome/browser and //ios/public/provider/chrome/browser
in preparation of moving chrome_browser_state.h.

Add a forwarding header to avoid breaking downstream once this CL
lands with the merge. It will be removed in a followup CL once all
the downstream code has been fixed to use the new header location.

Reformat the code with "git cl format ios/chrome".

BUG=437333
==========

to

==========
Remove the //ios/public/test target.

Move the test implementation of //ios/public/provider interfaces
to //ios/chrome/browser and //ios/public/provider/chrome/browser
in preparation of moving chrome_browser_state.h.

Add a forwarding header to avoid breaking downstream once this CL
lands with the merge. It will be removed in a followup CL once all
the downstream code has been fixed to use the new header location.

Reformat the code with "git cl format ios/chrome".

BUG=437333

Committed: https://crrev.com/a2b657a54e8f37ad664957f40d7b385c990c89c4
Cr-Commit-Position: refs/heads/master@{#373238}
==========

[commit-bot: I haz the power, 2016-02-03 15:17:44]

Patchset 3 (id:??) landed as
https://crrev.com/a2b657a54e8f37ad664957f40d7b385c990c89c4
Cr-Commit-Position: refs/heads/master@{#373238}