Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1667683002: Removes explicit shutdown of TabRestoreService in ~Browser (Closed)

Created:
4 years, 10 months ago by reat
Modified:
4 years, 10 months ago
Reviewers:
delvin, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This code is no longer needed. Early versions of TRS took ownership of the NavigationController, hence destruction issues. That hasn't been the case for a long time. One of the problem with early destruction is connected with chrome.sessions api, while we create window - create incognito window - close the first window, TabRestoreService is destroyed, and there is no any possibility to have events on sessions.onChanged() for the new windows for profiles. This pr is based on discussion in https://codereview.chromium.org/1642583002/ R=Delvin@chromium.org,sky@chromium.org BUG= Committed: https://crrev.com/e5ab691aceb914c2e305ab6887f2598961ca768c Cr-Commit-Position: refs/heads/master@{#373754}

Patch Set 1 #

Patch Set 2 : Fix patch: rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M chrome/browser/ui/browser.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
reat
Patch which removes obsolete code.
4 years, 10 months ago (2016-02-03 10:57:34 UTC) #1
sky
Please change the title to something like: "Removes explicit shutdown of TabRestoreService in ~Browser" You ...
4 years, 10 months ago (2016-02-03 17:22:18 UTC) #2
reat
I update issue.
4 years, 10 months ago (2016-02-04 06:04:51 UTC) #4
sky
Thanks, LGTM
4 years, 10 months ago (2016-02-04 17:31:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667683002/1
4 years, 10 months ago (2016-02-05 04:44:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/126879)
4 years, 10 months ago (2016-02-05 04:46:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667683002/20001
4 years, 10 months ago (2016-02-05 05:02:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 05:48:38 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 05:49:22 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5ab691aceb914c2e305ab6887f2598961ca768c
Cr-Commit-Position: refs/heads/master@{#373754}

Powered by Google App Engine
This is Rietveld 408576698