Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2821)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1667683002: Removes explicit shutdown of TabRestoreService in ~Browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix patch: rebase to master Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 942b4abe2d77beb7bb7f726d5953dc1d106cded3..1790b0672d5759e3ce07341e6f3e998d8a835bb4 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -523,21 +523,6 @@ Browser::~Browser() {
if (tab_restore_service)
tab_restore_service->BrowserClosed(live_tab_context());
-#if !defined(OS_MACOSX)
- if (!chrome::GetBrowserCount(profile_)) {
- // We're the last browser window with this profile. We need to nuke the
- // TabRestoreService, which will start the shutdown of the
- // NavigationControllers and allow for proper shutdown. If we don't do this
- // chrome won't shutdown cleanly, and may end up crashing when some
- // thread tries to use the IO thread (or another thread) that is no longer
- // valid.
- // This isn't a valid assumption for Mac OS, as it stays running after
- // the last browser has closed. The Mac equivalent is in its app
- // controller.
- TabRestoreServiceFactory::ResetForProfile(profile_);
- }
-#endif
-
profile_pref_registrar_.RemoveAll();
encoding_auto_detect_.Destroy();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698