[Ignition] Use separate startup data for ignition.

[Ignition] Use separate startup data for ignition.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/5a0df034d14674e789c447161fec96d3cfa836a5
Cr-Commit-Position: refs/heads/master@{#33724}

[Michael Achenbach, 2016-02-03 15:03:29]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 15:03:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667673003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667673003/20001

[commit-bot: I haz the power, 2016-02-03 15:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 15:06:59]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[Michael Achenbach, 2016-02-03 15:37:51]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2016-02-03 15:37:51]

Has anybody an idea what headache the bots might have?

[Michael Achenbach, 2016-02-03 15:48:06]

https://codereview.chromium.org/1667673003/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1667673003/diff/20001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:304: 'mksnapshot_flags': [
Hmm, my suspicion is that these mksnapshot_flags and the ones below get
magically concatenated by gyp. I'll try with a different var name...

[Michael Achenbach, 2016-02-03 16:40:07]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 16:40:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667673003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667673003/40001

[commit-bot: I haz the power, 2016-02-03 16:42:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 16:42:27]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[Michael Achenbach, 2016-02-04 08:54:59]

Looks like with my patch in v8.gyp, the natives_blob.bin dependency is removed
from d8.ninja. Why, why, why?

[Michael Achenbach, 2016-02-04 09:00:40]

On 2016/02/04 08:54:59, Michael Achenbach wrote:
> Looks like with my patch in v8.gyp, the natives_blob.bin dependency is removed
> from d8.ninja. Why, why, why?

OK - found it. My bad really. Duplicate condition key. Latter overwrites the
first ...

[Michael Achenbach, 2016-02-04 09:32:51]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 09:32:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667673003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667673003/60001

[commit-bot: I haz the power, 2016-02-04 09:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 09:49:40]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-02-04 09:53:47]

> > Looks like with my patch in v8.gyp, the natives_blob.bin dependency is
removed
?
> > from d8.ninja. Why, why, why?
>
> OK - found it. My bad really. Duplicate condition key. Latter overwrites the
> first ...

Ahh the joys of gyp... the GN migration can't come soon enough! :)

LGTM, thanks!

https://codereview.chromium.org/1667673003/diff/60001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1667673003/diff/60001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:287: # supported.
Do we have Android perf bots we could run the tests on? If so, could we make
this a TODO since it would be good to get numbers on Android too eventually.

[Michael Achenbach, 2016-02-04 10:09:51]

Description was changed from

==========
[Ignition] Use separate startup data for ignition.

BUG=
==========

to

==========
[Ignition] Use separate startup data for ignition.

BUG=v8:4280
LOG=N
==========

[Michael Achenbach, 2016-02-04 10:10:23]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-02-04 10:10:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667673003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667673003/60001

[Michael Achenbach, 2016-02-04 10:10:38]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-02-04 10:10:45]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-02-04 10:10:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667673003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667673003/60001

[Yang, 2016-02-04 10:11:36]

C++ code lgtm.

https://codereview.chromium.org/1667673003/diff/60001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1667673003/diff/60001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:307: 'mksnapshot_flags_ignition': ['--random-seed',
'<(v8_random_seed)'],
do we still care about 80-char limit here and below?

[Michael Achenbach, 2016-02-04 10:14:17]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-02-04 10:14:27]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-02-04 10:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667673003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667673003/60001

[Michael Achenbach, 2016-02-04 10:16:00]

https://codereview.chromium.org/1667673003/diff/60001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1667673003/diff/60001/tools/gyp/v8.gyp#newcod...
tools/gyp/v8.gyp:307: 'mksnapshot_flags_ignition': ['--random-seed',
'<(v8_random_seed)'],
On 2016/02/04 10:11:36, Yang wrote:
> do we still care about 80-char limit here and below?

In gyp files not really. There are lots of other violations all over the
place...

[commit-bot: I haz the power, 2016-02-04 10:17:47]

Description was changed from

==========
[Ignition] Use separate startup data for ignition.

BUG=v8:4280
LOG=N
==========

to

==========
[Ignition] Use separate startup data for ignition.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-02-04 10:17:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-04 10:18:16]

Description was changed from

==========
[Ignition] Use separate startup data for ignition.

BUG=v8:4280
LOG=N
==========

to

==========
[Ignition] Use separate startup data for ignition.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/5a0df034d14674e789c447161fec96d3cfa836a5
Cr-Commit-Position: refs/heads/master@{#33724}
==========

[commit-bot: I haz the power, 2016-02-04 10:18:16]

Patchset 4 (id:??) landed as
https://crrev.com/5a0df034d14674e789c447161fec96d3cfa836a5
Cr-Commit-Position: refs/heads/master@{#33724}