Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: tools/gyp/v8.gyp

Issue 1667673003: [Ignition] Use separate startup data for ignition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move to correct condition section. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/startup-data-util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index c418aa737a878e0e48934a6851d1dfdb6c54eea9..97fc60aee2e2a332ab954a6ddf9a0202b5310993 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -283,6 +283,46 @@
],
},
}],
+ # Extra snapshot blob for ignition. Separate host toolset is not
+ # supported.
rmcilroy 2016/02/04 09:53:47 Do we have Android perf bots we could run the test
+ ['v8_separate_ignition_snapshot==1', {
+ # This is concatenated to the other actions list of
+ # v8_external_snapshot.
+ 'actions': [
+ {
+ 'action_name': 'run_mksnapshot (ignition)',
+ 'inputs': [
+ '<(mksnapshot_exec)',
+ ],
+ 'variables': {
+ # TODO: Extract common mksnapshot_flags to a separate
+ # variable.
+ 'mksnapshot_flags_ignition': [
+ '--ignition',
+ '--log-snapshot-positions',
+ '--logfile', '<(INTERMEDIATE_DIR)/snapshot_ignition.log',
+ ],
+ 'conditions': [
+ ['v8_random_seed!=0', {
+ 'mksnapshot_flags_ignition': ['--random-seed', '<(v8_random_seed)'],
Yang 2016/02/04 10:11:36 do we still care about 80-char limit here and belo
Michael Achenbach 2016/02/04 10:16:00 In gyp files not really. There are lots of other v
+ }],
+ ['v8_vector_stores!=0', {
+ 'mksnapshot_flags_ignition': ['--vector-stores'],
+ }],
+ ],
+ },
+ 'outputs': [
+ '<(PRODUCT_DIR)/snapshot_blob_ignition.bin',
+ ],
+ 'action': [
+ '<(mksnapshot_exec)',
+ '<@(mksnapshot_flags_ignition)',
+ '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition.bin',
+ '<(embed_script)',
+ ],
+ },
+ ],
+ }],
],
'dependencies': [
'v8_base',
« no previous file with comments | « src/startup-data-util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698