Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: tools/gyp/v8.gyp

Issue 1667673003: [Ignition] Use separate startup data for ignition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move to correct condition section. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/startup-data-util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 'V8_SHARED', 276 'V8_SHARED',
277 'BUILDING_V8_SHARED', 277 'BUILDING_V8_SHARED',
278 ], 278 ],
279 'direct_dependent_settings': { 279 'direct_dependent_settings': {
280 'defines': [ 280 'defines': [
281 'V8_SHARED', 281 'V8_SHARED',
282 'USING_V8_SHARED', 282 'USING_V8_SHARED',
283 ], 283 ],
284 }, 284 },
285 }], 285 }],
286 # Extra snapshot blob for ignition. Separate host toolset is not
287 # supported.
rmcilroy 2016/02/04 09:53:47 Do we have Android perf bots we could run the test
288 ['v8_separate_ignition_snapshot==1', {
289 # This is concatenated to the other actions list of
290 # v8_external_snapshot.
291 'actions': [
292 {
293 'action_name': 'run_mksnapshot (ignition)',
294 'inputs': [
295 '<(mksnapshot_exec)',
296 ],
297 'variables': {
298 # TODO: Extract common mksnapshot_flags to a separate
299 # variable.
300 'mksnapshot_flags_ignition': [
301 '--ignition',
302 '--log-snapshot-positions',
303 '--logfile', '<(INTERMEDIATE_DIR)/snapshot_ignition.log',
304 ],
305 'conditions': [
306 ['v8_random_seed!=0', {
307 'mksnapshot_flags_ignition': ['--random-seed', '<(v8_ran dom_seed)'],
Yang 2016/02/04 10:11:36 do we still care about 80-char limit here and belo
Michael Achenbach 2016/02/04 10:16:00 In gyp files not really. There are lots of other v
308 }],
309 ['v8_vector_stores!=0', {
310 'mksnapshot_flags_ignition': ['--vector-stores'],
311 }],
312 ],
313 },
314 'outputs': [
315 '<(PRODUCT_DIR)/snapshot_blob_ignition.bin',
316 ],
317 'action': [
318 '<(mksnapshot_exec)',
319 '<@(mksnapshot_flags_ignition)',
320 '--startup_blob', '<(PRODUCT_DIR)/snapshot_blob_ignition.bin ',
321 '<(embed_script)',
322 ],
323 },
324 ],
325 }],
286 ], 326 ],
287 'dependencies': [ 327 'dependencies': [
288 'v8_base', 328 'v8_base',
289 ], 329 ],
290 'include_dirs+': [ 330 'include_dirs+': [
291 '../..', 331 '../..',
292 ], 332 ],
293 'sources': [ 333 'sources': [
294 '../../src/snapshot/natives-external.cc', 334 '../../src/snapshot/natives-external.cc',
295 '../../src/snapshot/snapshot-external.cc', 335 '../../src/snapshot/snapshot-external.cc',
(...skipping 1839 matching lines...) Expand 10 before | Expand all | Expand 10 after
2135 }], 2175 }],
2136 ['want_separate_host_toolset==1', { 2176 ['want_separate_host_toolset==1', {
2137 'toolsets': ['host'], 2177 'toolsets': ['host'],
2138 }, { 2178 }, {
2139 'toolsets': ['target'], 2179 'toolsets': ['target'],
2140 }], 2180 }],
2141 ], 2181 ],
2142 }, 2182 },
2143 ], 2183 ],
2144 } 2184 }
OLDNEW
« no previous file with comments | « src/startup-data-util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698