Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1670863002: QUIC - minor cleanup changes to keep code in sync with the internal source. (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0204
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - minor cleanup changes to keep code in sync with the internal source. R=rch@chromium.org Committed: https://crrev.com/55a807c89d050f4aee2041836badccd85a85cb63 Cr-Commit-Position: refs/heads/master@{#373733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M net/quic/crypto/crypto_handshake.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_arena_scoped_ptr_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_multipath_transmissions_map.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_one_block_arena.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_per_connection_packet_writer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_per_connection_packet_writer.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1667583004 Patch 80001

Messages

Total messages: 11 (4 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-05 01:02:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670863002/1
4 years, 10 months ago (2016-02-05 01:07:13 UTC) #3
Ryan Hamilton
lgtm
4 years, 10 months ago (2016-02-05 01:20:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 02:49:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670863002/1
4 years, 10 months ago (2016-02-05 02:57:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 03:06:01 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 03:08:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/55a807c89d050f4aee2041836badccd85a85cb63
Cr-Commit-Position: refs/heads/master@{#373733}

Powered by Google App Engine
This is Rietveld 408576698