Subzero: change Inst->Instr in many place to follow newer convention.

Following the newer convention enhances readability and in addition this is a prelude to some macro changes in unimplemented I would like to make in order to simplify that code.

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=04bca5a57784a630ffb31c405f2da1f1b43d086e

[rkotlerimgtec, 2016-02-03 02:57:23]

Description was changed from

==========
Subzero: change Inst->Instr in many place to follow newer convention.

BUG=
==========

to

==========
Following the newer convention enhances readability and in addition this is a
prelude to some macro changes in unimplemented I would like to make in order to
simplify that code.

BUG=
==========

[rkotlerimgtec, 2016-02-03 02:57:23]

rkotlerimgtec@gmail.com changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[rkotlerimgtec, 2016-02-03 04:25:47]

Forgot to hit save and missed a few of the Inst->Instr changes.

[Jim Stichnoth, 2016-02-03 05:03:23]

Might as well also change the instances in IceTargetLoweringMIPS32.h .

https://codereview.chromium.org/1667553002/diff/20001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/1667553002/diff/20001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:1088: void TargetMIPS32::lowerPhi(const InstPhi
* /*Inst*/) {
Maybe change this comment too, for completeness?

[rkotlerimgtec, 2016-02-03 22:06:39]

https://codereview.chromium.org/1667553002/diff/20001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/1667553002/diff/20001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:1088: void TargetMIPS32::lowerPhi(const InstPhi
* /*Inst*/) {
On 2016/02/03 05:03:23, stichnot wrote:
> Maybe change this comment too, for completeness?

Done.

[Jim Stichnoth, 2016-02-03 22:40:14]

lgtm

[Jim Stichnoth, 2016-02-03 22:40:50]

Description was changed from

==========
Following the newer convention enhances readability and in addition this is a
prelude to some macro changes in unimplemented I would like to make in order to
simplify that code.

BUG=
==========

to

==========
Following the newer convention enhances readability and in addition this is a
prelude to some macro changes in unimplemented I would like to make in order to
simplify that code.

BUG=
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-02-03 22:40:52]

Committed patchset #3 (id:40001) manually as
04bca5a57784a630ffb31c405f2da1f1b43d086e (presubmit successful).