Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1666893003: [ABANDONED] WebSocket Blob receive in the browser process: renderer changes (Closed)

Created:
4 years, 10 months ago by Adam Rice
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, kinuko
Base URL:
https://chromium.googlesource.com/chromium/src.git@websocket_blob_receive_host_merged
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ABANDONED] WebSocket Blob receive in the browser process: renderer changes Modify the renderer to be able to handle Blobs received entirely in the browser process. Mostly just interface changes; the only tricky part is the case where binaryType was changed after the message started being received, in which case we have to fix it up so that the message callback is called with the correct type. See the design outline at https://docs.google.com/document/d/1xL04I0GpA6VKk6XJUEsnqwPBu5ROGoWbiO_vciVP8d8/edit BUG=580615 TEST=webkit_unit_tests, layout tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -33 lines) Patch
M content/child/websocket_bridge.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/child/websocket_bridge.cc View 4 chunks +42 lines, -0 lines 0 comments Download
M content/child/websocket_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.h View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 4 chunks +45 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 3 chunks +33 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 8 chunks +19 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketChannel.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h View 4 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 4 chunks +36 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSocketChannelClientProxy.h View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSocketImpl.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSocketImpl.cpp View 3 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/websockets/WebSocketHandleClient.h View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1664743002 Patch 20001

Messages

Total messages: 2 (2 generated)
Adam Rice
Description was changed from ========== [WIP] WebSocket Blob receive in the browser process: renderer changes ...
4 years, 10 months ago (2016-02-04 13:53:22 UTC) #1
Adam Rice
4 years, 3 months ago (2016-09-12 05:59:28 UTC) #2 
Description was changed from

==========
[WIP] WebSocket Blob receive in the browser process: renderer changes

Modify the renderer to be able to handle Blobs received entirely
in the browser process. Mostly just interface changes; the only
tricky part is the case where binaryType was changed after the
message started being received, in which case we have to fix it up
so that the message callback is called with the correct type.

See the design outline at
https://docs.google.com/document/d/1xL04I0GpA6VKk6XJUEsnqwPBu5ROGoWbiO_vciVP8...

BUG=580615
TEST=webkit_unit_tests, layout tests
==========

to

==========
[ABANDONED] WebSocket Blob receive in the browser process: renderer changes

Modify the renderer to be able to handle Blobs received entirely
in the browser process. Mostly just interface changes; the only
tricky part is the case where binaryType was changed after the
message started being received, in which case we have to fix it up
so that the message callback is called with the correct type.

See the design outline at
https://docs.google.com/document/d/1xL04I0GpA6VKk6XJUEsnqwPBu5ROGoWbiO_vciVP8...

BUG=580615
TEST=webkit_unit_tests, layout tests
==========

Powered by Google App Engine
This is Rietveld 408576698