Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1664743002: [OBSOLETE][DO NOT SUBMIT][DO NOT COMMIT]] Browser-side implementation of WebSocket Blob receive. (Closed)

Created:
4 years, 10 months ago by Adam Rice
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, kinuko
Base URL:
https://chromium.googlesource.com/chromium/src.git@websocket_blob_send_sender
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Browser-side implementation of WebSocket Blob receive. This is a temporary version of the CL until https://codereview.chromium.org/1568523002/ can be landed. These changes will probably be merged back into https://codereview.chromium.org/1626453003/ when that happens. BUG=580615 TEST=content_unittests SUBMIT=no

Patch Set 1 #

Patch Set 2 : Now actually works. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1395 lines, -50 lines) Patch
M content/browser/bad_message.h View 1 chunk +2 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_blob_receiver.h View 1 chunk +148 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_blob_receiver.cc View 1 chunk +322 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_blob_receiver_unittest.cc View 1 chunk +370 lines, -0 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/websocket_host.h View 1 6 chunks +129 lines, -1 line 0 comments Download
M content/browser/renderer_host/websocket_host.cc View 1 25 chunks +368 lines, -46 lines 0 comments Download
M content/common/websocket.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/common/websocket_messages.h View 3 chunks +28 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_event_interface.h View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (4 generated)
Adam Rice
4 years, 10 months ago (2016-02-04 13:45:01 UTC) #4
Sorry, this is not ready for review yet, I just meant to add kinuko to the CC
list.

Powered by Google App Engine
This is Rietveld 408576698