third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: testts Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ScriptCallFrame.h ('k') | third_party/WebKit/Source/core/inspector/ScriptCallStack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp b/third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp

index d044abd946dfb1ee4a378b5cf5ef3f6c460ca1e6..420ad1f6f83048a1ac634d97f7aa4801b92366b3 100644

--- a/third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp

+++ b/third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp

@@ -58,9 +58,9 @@ ScriptCallFrame::~ScriptCallFrame()

// buildInspectorObject() and toTracedValue() should set the same fields.

// If either of them is modified, the other should be also modified.

-PassRefPtr<TypeBuilder::Console::CallFrame> ScriptCallFrame::buildInspectorObject() const

+PassRefPtr<TypeBuilder::Runtime::CallFrame> ScriptCallFrame::buildInspectorObject() const

{

- return TypeBuilder::Console::CallFrame::create()

+ return TypeBuilder::Runtime::CallFrame::create()

.setFunctionName(m_functionName)

.setScriptId(m_scriptId)

.setUrl(m_scriptName)