Issue 1664763003: Rename QUIC connection timeout error codes to be more descriptive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1664763003: Rename QUIC connection timeout error codes to be more descriptive. (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)

Modified:
4 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade

Base URL:
https://chromium.googlesource.com/chromium/src.git@113275797

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename QUIC connection timeout error codes to be more descriptive. No behavior change. Renames: QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT To future Chromium merger: You will need to update histograms.xml in Chromium, for the mapping from error code -> UMA string. Merge internal change: 113294280 R=rch@chromium.org

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -51 lines)			Patch
M	net/quic/quic_chromium_client_session.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_connection.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	7 chunks	+16 lines, -18 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	9 chunks	+12 lines, -13 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	net/quic/quic_stream_factory_test.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	net/quic/quic_utils.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1662083003 Patch 1

Dependent Patchsets:

Issue 1664973002 Patch 1

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

On 2016/02/03 21:56:45, ramant wrote: Hi Ryan and Robbie, Will upload another CL that adds ...

4 years, 10 months ago (2016-02-03 21:57:34 UTC) #2

Ryan Hamilton

4 years, 10 months ago (2016-02-04 00:15:03 UTC) #3

On 2016/02/03 21:57:34, ramant wrote:
> On 2016/02/03 21:56:45, ramant wrote:
> 
> Hi Ryan and Robbie,
>   Will upload another CL that adds all missing error codes to histograms.xml.

Thanks!

LGTM

Expand Messages | Collapse Messages