Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: net/quic/quic_chromium_client_session.cc

Issue 1664763003: Rename QUIC connection timeout error codes to be more descriptive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@113275797
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_chromium_client_session.h" 5 #include "net/quic/quic_chromium_client_session.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
706 } else { 706 } else {
707 if (IsCryptoHandshakeConfirmed()) { 707 if (IsCryptoHandshakeConfirmed()) {
708 UMA_HISTOGRAM_SPARSE_SLOWLY( 708 UMA_HISTOGRAM_SPARSE_SLOWLY(
709 "Net.QuicSession.ConnectionCloseErrorCodeClient.HandshakeConfirmed", 709 "Net.QuicSession.ConnectionCloseErrorCodeClient.HandshakeConfirmed",
710 error); 710 error);
711 } 711 }
712 UMA_HISTOGRAM_SPARSE_SLOWLY( 712 UMA_HISTOGRAM_SPARSE_SLOWLY(
713 "Net.QuicSession.ConnectionCloseErrorCodeClient", error); 713 "Net.QuicSession.ConnectionCloseErrorCodeClient", error);
714 } 714 }
715 715
716 if (error == QUIC_CONNECTION_TIMED_OUT) { 716 if (error == QUIC_NETWORK_IDLE_TIMEOUT) {
717 UMA_HISTOGRAM_COUNTS( 717 UMA_HISTOGRAM_COUNTS(
718 "Net.QuicSession.ConnectionClose.NumOpenStreams.TimedOut", 718 "Net.QuicSession.ConnectionClose.NumOpenStreams.TimedOut",
719 GetNumOpenOutgoingStreams()); 719 GetNumOpenOutgoingStreams());
720 if (IsCryptoHandshakeConfirmed()) { 720 if (IsCryptoHandshakeConfirmed()) {
721 if (GetNumOpenOutgoingStreams() > 0) { 721 if (GetNumOpenOutgoingStreams() > 0) {
722 disabled_reason_ = QUIC_DISABLED_TIMEOUT_WITH_OPEN_STREAMS; 722 disabled_reason_ = QUIC_DISABLED_TIMEOUT_WITH_OPEN_STREAMS;
723 UMA_HISTOGRAM_BOOLEAN( 723 UMA_HISTOGRAM_BOOLEAN(
724 "Net.QuicSession.TimedOutWithOpenStreams.HasUnackedPackets", 724 "Net.QuicSession.TimedOutWithOpenStreams.HasUnackedPackets",
725 connection()->sent_packet_manager().HasUnackedPackets()); 725 connection()->sent_packet_manager().HasUnackedPackets());
726 UMA_HISTOGRAM_COUNTS( 726 UMA_HISTOGRAM_COUNTS(
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 } 1018 }
1019 1019
1020 const DatagramClientSocket* QuicChromiumClientSession::GetDefaultSocket() 1020 const DatagramClientSocket* QuicChromiumClientSession::GetDefaultSocket()
1021 const { 1021 const {
1022 DCHECK(sockets_.back().get() != nullptr); 1022 DCHECK(sockets_.back().get() != nullptr);
1023 // The most recently added socket is the currently active one. 1023 // The most recently added socket is the currently active one.
1024 return sockets_.back().get(); 1024 return sockets_.back().get();
1025 } 1025 }
1026 1026
1027 } // namespace net 1027 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_connection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698