Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1664653003: Revert of Move gn _run target generation into test(). (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 10 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, nektar+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dmazzoni+watch_chromium.org, tdresser+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, blink-reviews-wtf_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, Matt Giuca, toyoshim+midi_chromium.org, aboxhall+watch_chromium.org, samuong+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, marcinjb+watch-blimp_chromium.org, je_julie, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, chromoting-reviews_chromium.org, imcheng+watch_chromium.org, tapted, jasonroberts+watch_google.com, rickyz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, darin (slow to review), anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, plundblad+watch_chromium.org, Ian Vollick, tfarina, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, plaree+watch_chromium.org, dtseng+watch_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org, isheriff+watch_chromium.org, jln+watch_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move gn _run target generation into test(). (patchset #1 id:1 of https://codereview.chromium.org/1653003006/ ) Reason for revert: Broke angle_unittests_run, which doesn't follow the template: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53646/steps/compile/logs/stdio Original issue's description: > Move gn _run target generation into test(). > > TBR=brettw@chromium.org > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a > Cr-Commit-Position: refs/heads/master@{#373232} TBR=phosek@chromium.org,brettw@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/002f2226477126a477d38086b119073911fa231d Cr-Commit-Position: refs/heads/master@{#373257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+589 lines, -26 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M blimp/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +36 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M components/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
M components/nacl/loader/BUILD.gn View 2 chunks +28 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +27 lines, -0 lines 0 comments Download
M crypto/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M device/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M gin/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M google_apis/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/BUILD.gn View 3 chunks +25 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ipc/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M jingle/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M media/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M media/cast/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M media/midi/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +40 lines, -0 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M printing/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M remoting/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -10 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M sql/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M testing/test.gni View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/cacheinvalidation/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/battor_agent/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/gn/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/display/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/touch_selection/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M url/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Dirk Pranke
Created Revert of Move gn _run target generation into test().
4 years, 10 months ago (2016-02-03 16:55:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664653003/1
4 years, 10 months ago (2016-02-03 16:55:48 UTC) #2
Dirk Pranke
4 years, 10 months ago (2016-02-03 16:56:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 16:57:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/002f2226477126a477d38086b119073911fa231d Cr-Commit-Position: refs/heads/master@{#373257}
4 years, 10 months ago (2016-02-03 16:59:50 UTC) #8
Dirk Pranke
On 2016/02/03 16:59:50, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 10 months ago (2016-02-03 17:00:49 UTC) #9
Ken Russell (switch to Gerrit)
On 2016/02/03 17:00:49, Dirk Pranke wrote: > On 2016/02/03 16:59:50, commit-bot: I haz the power ...
4 years, 10 months ago (2016-02-03 17:03:08 UTC) #10
jbudorick
4 years, 10 months ago (2016-02-03 17:04:46 UTC) #11
Message was sent while issue was closed.
On 2016/02/03 17:00:49, Dirk Pranke wrote:
> On 2016/02/03 16:59:50, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/002f2226477126a477d38086b119073911fa231d
> > Cr-Commit-Position: refs/heads/master@{#373257}
> 
> Whoops. I thought it broke angle_unittests, but apparently it was
> angle_end2end_tests, which this CL didn't even touch.

Reverting this CL does let GN find angle_end2end_tests_run, though, so it must
have affected that target indirectly somehow. Still investigating.

Powered by Google App Engine
This is Rietveld 408576698