Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: extensions/BUILD.gn

Issue 1664653003: Revert of Move gn _run target generation into test(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/BUILD.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # TODO(rockot) bug 505926: Don't include chrome files from here. 5 # TODO(rockot) bug 505926: Don't include chrome files from here.
6 # See chrome_browser_tests_extensions_sources below 6 # See chrome_browser_tests_extensions_sources below
7 import("//chrome/chrome_tests.gni") 7 import("//chrome/chrome_tests.gni")
8 import("//extensions/extensions.gni") 8 import("//extensions/extensions.gni")
9 import("//testing/test.gni") 9 import("//testing/test.gni")
10 import("//tools/grit/grit_rule.gni") 10 import("//tools/grit/grit_rule.gni")
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 "//content/shell:resources", 134 "//content/shell:resources",
135 "//extensions/shell:resources", 135 "//extensions/shell:resources",
136 "//extensions/strings", 136 "//extensions/strings",
137 "//third_party/WebKit/public:image_resources", 137 "//third_party/WebKit/public:image_resources",
138 "//third_party/WebKit/public:resources", 138 "//third_party/WebKit/public:resources",
139 "//ui/resources", 139 "//ui/resources",
140 "//ui/strings", 140 "//ui/strings",
141 ] 141 ]
142 } 142 }
143 143
144 # TODO(GYP): Delete this after we've converted everything to GN.
145 # The _run targets exist only for compatibility w/ GYP.
146 group("extensions_unittests_run") {
147 testonly = true
148 deps = [
149 ":extensions_unittests",
150 ]
151 }
152
144 test("extensions_unittests") { 153 test("extensions_unittests") {
145 sources = 154 sources =
146 rebase_path(extensions_tests_gypi_values.extensions_unittests_sources, 155 rebase_path(extensions_tests_gypi_values.extensions_unittests_sources,
147 ".", 156 ".",
148 "//extensions") 157 "//extensions")
149 158
150 sources += [ 159 sources += [
151 # TODO(rockot): DisplayInfoProvider::Create() is only implemented in Chrome 160 # TODO(rockot): DisplayInfoProvider::Create() is only implemented in Chrome
152 # and app_shell. This is wrong. 161 # and app_shell. This is wrong.
153 "shell/browser/shell_display_info_provider.cc", 162 "shell/browser/shell_display_info_provider.cc",
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 211
203 # TODO(rockot): There are two implementations of VpnServiceFactory, a 212 # TODO(rockot): There are two implementations of VpnServiceFactory, a
204 # stub in app_shell and a real one in Chrome. This is wrong. 213 # stub in app_shell and a real one in Chrome. This is wrong.
205 "shell/browser/api/vpn_provider/vpn_service_factory.cc", 214 "shell/browser/api/vpn_provider/vpn_service_factory.cc",
206 ] 215 ]
207 216
208 deps += [ "//chromeos:test_support" ] 217 deps += [ "//chromeos:test_support" ]
209 } 218 }
210 } 219 }
211 220
221 # TODO(GYP): Delete this after we've converted everything to GN.
222 # The _run targets exist only for compatibility w/ GYP.
223 group("extensions_browsertests_run") {
224 testonly = true
225 deps = [
226 ":extensions_browsertests",
227 ]
228 }
229
212 test("extensions_browsertests") { 230 test("extensions_browsertests") {
213 sources = 231 sources =
214 rebase_path(extensions_tests_gypi_values.extensions_browsertests_sources, 232 rebase_path(extensions_tests_gypi_values.extensions_browsertests_sources,
215 ".", 233 ".",
216 "//extensions") 234 "//extensions")
217 235
218 data = [ 236 data = [
219 "test/data/", 237 "test/data/",
220 "//net/data/", 238 "//net/data/",
221 "//net/tools/testserver/", 239 "//net/tools/testserver/",
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 "//testing/gtest", 387 "//testing/gtest",
370 "//third_party/hunspell", 388 "//third_party/hunspell",
371 "//third_party/icu", 389 "//third_party/icu",
372 "//third_party/libpng", 390 "//third_party/libpng",
373 "//third_party/zlib", 391 "//third_party/zlib",
374 "//ui/base:test_support", 392 "//ui/base:test_support",
375 "//ui/resources:ui_test_pak", 393 "//ui/resources:ui_test_pak",
376 "//ui/web_dialogs:test_support", 394 "//ui/web_dialogs:test_support",
377 ] 395 ]
378 } 396 }
OLDNEW
« no previous file with comments | « device/BUILD.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698