Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: components/nacl/loader/BUILD.gn

Issue 1664653003: Revert of Move gn _run target generation into test(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/loader/BUILD.gn
diff --git a/components/nacl/loader/BUILD.gn b/components/nacl/loader/BUILD.gn
index 6a8c161c9caf3d8415fad0179c6ef62768f207d4..038fc37f9ff0976271500e3971f099b6771aa6f0 100644
--- a/components/nacl/loader/BUILD.gn
+++ b/components/nacl/loader/BUILD.gn
@@ -71,6 +71,15 @@
]
}
+# TODO(GYP): Delete this after we've converted everything to GN.
+# The _run targets exist only for compatibility w/ GYP.
+group("nacl_loader_unittests_run") {
+ testonly = true
+ deps = [
+ ":nacl_loader_unittests",
+ ]
+}
+
test("nacl_loader_unittests") {
sources = [
"nacl_ipc_adapter_unittest.cc",
@@ -147,14 +156,29 @@
"//base",
"//base/test:test_launcher_nacl_nonsfi",
]
- data_deps = [
+ }
+
+ group("helper_nonsfi") {
+ data_deps = [
+ ":nacl_helper_nonsfi_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
+ ]
+ }
+
+ group("helper_nonsfi_unittests") {
+ testonly = true
+ data_deps = [
+ ":nacl_helper_nonsfi_unittests",
":nacl_helper_nonsfi_unittests_main_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
]
}
- group("helper_nonsfi") {
- data_deps = [
- ":nacl_helper_nonsfi_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
+ # TODO(GYP): Delete this after we've converted everything to GN.
+ # The _run targets exist only for compatibility w/ GYP.
+ group("nacl_helper_nonsfi_unittests_run") {
+ testonly = true
+ data_deps = [
+ ":helper_nonsfi_unittests",
+ ":nacl_helper_nonsfi_unittests_main_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
]
}
}
« no previous file with comments | « components/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698