Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 182573002: IDL compiler: Filter files during pre-caching of templates (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

IDL compiler: Filter files during pre-caching of templates code_generator_v8.py dies on build bots because it tries to cache '.svn', and is fragile to other files being added (e.g., subdirectories). This fixes it by filtering to only cache .cpp and .h files. BUG=239771 TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/bindings/scripts/unstable/code_generator_v8.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Fix for build bots.
6 years, 10 months ago (2014-02-27 02:00:56 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-27 02:01:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/182573002/1
6 years, 10 months ago (2014-02-27 02:01:11 UTC) #3
commit-bot: I haz the power
Change committed as 167955
6 years, 10 months ago (2014-02-27 02:01:23 UTC) #4
haraken
6 years, 10 months ago (2014-02-27 02:25:57 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698