Fix vector load/stores in the ARM assembler.

Fix vector load/stores in the ARM assembler.

Fixes emit() methods for load/store to specify the element size (affects
alignment issues).

Also adds assembler methods to generate the corresponding binary forms,
and updates emitIAS() to call these assembler methods.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=18cce427c2297b64f54125c82e30522226df0f0e

[Karl, 2016-02-04 18:49:56]

Description was changed from

==========
Fix vector load/stores in the ARM assembler.

Fixes emit() methods for load/store to specify the element size (effects
alignment issues).

Also adds assembler methods to generate the corresponding binary forms,
and updates emitIAS() to call these assembler methods.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Fix vector load/stores in the ARM assembler.

Fixes emit() methods for load/store to specify the element size (effects
alignment issues).

Also adds assembler methods to generate the corresponding binary forms,
and updates emitIAS() to call these assembler methods.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-02-04 18:49:56]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Karl, 2016-02-04 18:54:57]

Updated cross tests to now use filetype=obj.

[Jim Stichnoth, 2016-02-04 20:47:37]

lgtm

https://codereview.chromium.org/1663053008/diff/20001/src/DartARM32/assembler...
File src/DartARM32/assembler_arm.h (right):

https://codereview.chromium.org/1663053008/diff/20001/src/DartARM32/assembler...
src/DartARM32/assembler_arm.h:1408: // ARM32::AssemblerARM32:rbit().
remove the period here and above

https://codereview.chromium.org/1663053008/diff/30001/pydir/crosstest_generat...
File pydir/crosstest_generator.py (right):

https://codereview.chromium.org/1663053008/diff/30001/pydir/crosstest_generat...
pydir/crosstest_generator.py:69: # ARM doesn't have an ELF writer yet, and iasm
does not
Drop this comment and the override.  Yay!!!

https://codereview.chromium.org/1663053008/diff/30001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1663053008/diff/30001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1927: const Operand *Src0 = getSrc(0);
Maybe also "const Operand *Src1 = getSrc(1);" for symmetry below.

https://codereview.chromium.org/1663053008/diff/30001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vstr-vector.ll (right):

https://codereview.chromium.org/1663053008/diff/30001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vstr-vector.ll:3: ; Note: Uses -O2 to remove
unnecessary loads/stores, resulting in only
Reflow the comment

[Karl, 2016-02-04 21:37:53]

Description was changed from

==========
Fix vector load/stores in the ARM assembler.

Fixes emit() methods for load/store to specify the element size (effects
alignment issues).

Also adds assembler methods to generate the corresponding binary forms,
and updates emitIAS() to call these assembler methods.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Fix vector load/stores in the ARM assembler.

Fixes emit() methods for load/store to specify the element size (affects
alignment issues).

Also adds assembler methods to generate the corresponding binary forms,
and updates emitIAS() to call these assembler methods.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-02-04 21:54:57]

Description was changed from

==========
Fix vector load/stores in the ARM assembler.

Fixes emit() methods for load/store to specify the element size (affects
alignment issues).

Also adds assembler methods to generate the corresponding binary forms,
and updates emitIAS() to call these assembler methods.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Fix vector load/stores in the ARM assembler.

Fixes emit() methods for load/store to specify the element size (affects
alignment issues).

Also adds assembler methods to generate the corresponding binary forms,
and updates emitIAS() to call these assembler methods.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-02-04 21:54:58]

Committed patchset #4 (id:50001) manually as
18cce427c2297b64f54125c82e30522226df0f0e (presubmit successful).

[Karl, 2016-02-04 21:55:22]

https://codereview.chromium.org/1663053008/diff/20001/src/DartARM32/assembler...
File src/DartARM32/assembler_arm.h (right):

https://codereview.chromium.org/1663053008/diff/20001/src/DartARM32/assembler...
src/DartARM32/assembler_arm.h:1408: // ARM32::AssemblerARM32:rbit().
On 2016/02/04 20:47:36, stichnot wrote:
> remove the period here and above

Done.

https://codereview.chromium.org/1663053008/diff/30001/pydir/crosstest_generat...
File pydir/crosstest_generator.py (right):

https://codereview.chromium.org/1663053008/diff/30001/pydir/crosstest_generat...
pydir/crosstest_generator.py:69: # ARM doesn't have an ELF writer yet, and iasm
does not
On 2016/02/04 20:47:37, stichnot wrote:
> Drop this comment and the override.  Yay!!!

Done.

https://codereview.chromium.org/1663053008/diff/30001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1663053008/diff/30001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1927: const Operand *Src0 = getSrc(0);
On 2016/02/04 20:47:37, stichnot wrote:
> Maybe also "const Operand *Src1 = getSrc(1);" for symmetry below.

Done.

https://codereview.chromium.org/1663053008/diff/30001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vstr-vector.ll (right):

https://codereview.chromium.org/1663053008/diff/30001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vstr-vector.ll:3: ; Note: Uses -O2 to remove
unnecessary loads/stores, resulting in only
On 2016/02/04 20:47:37, stichnot wrote:
> Reflow the comment

Done.