Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

This change removes dependency on StreamChannelFactory and
P2PStreamSocket from ChannelDispatcherBase. This allow to use channel
dispatchers without the old message framing mechanism that doesn't
make sense for WebRTC-based protocol.

BUG=547158
Committed: https://crrev.com/786463e2ba806e5ed9d08b6ab9333210dd0b8772
Cr-Commit-Position: refs/heads/master@{#373571}

[Sergey Ulanov, 2016-02-02 21:32:02]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-02-03 02:00:55]

Description was changed from

==========
Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

This change removes dependency on StreamChanneFactory and
P2PStreamSocket from ChannelDisparcherBase. This allow to use channel
dispatchers without the old message framing mechanism that doesn't
make sense for WebRTC-based protocol.

BUG=547158
==========

to

==========
Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

This change removes dependency on StreamChannelFactory and
P2PStreamSocket from ChannelDispatcherBase. This allow to use channel
dispatchers without the old message framing mechanism that doesn't
make sense for WebRTC-based protocol.

BUG=547158
==========

[Jamie, 2016-02-03 02:01:02]

lgtm

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/messa...
File remoting/protocol/message_channel_factory.h (right):

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/messa...
remoting/protocol/message_channel_factory.h:26: // call returns. If channel
channel creation fails the callback is never
Duplicate "channel".

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/strea...
File remoting/protocol/stream_message_pipe_adapter.cc (right):

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/strea...
remoting/protocol/stream_message_pipe_adapter.cc:64:
StreamMessageChannelFactoryAdapter::~StreamMessageChannelFactoryAdapter() {}
Blank line after non-trivial ctor?

[Sergey Ulanov, 2016-02-03 20:09:06]

Patchset #5 (id:80001) has been deleted

[Sergey Ulanov, 2016-02-03 20:09:19]

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/messa...
File remoting/protocol/message_channel_factory.h (right):

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/messa...
remoting/protocol/message_channel_factory.h:26: // call returns. If channel
channel creation fails the callback is never
On 2016/02/03 02:01:02, Jamie wrote:
> Duplicate "channel".

Done.

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/strea...
File remoting/protocol/stream_message_pipe_adapter.cc (right):

https://codereview.chromium.org/1662673002/diff/40001/remoting/protocol/strea...
remoting/protocol/stream_message_pipe_adapter.cc:64:
StreamMessageChannelFactoryAdapter::~StreamMessageChannelFactoryAdapter() {}
On 2016/02/03 02:01:02, Jamie wrote:
> Blank line after non-trivial ctor?

Done.

[Sergey Ulanov, 2016-02-04 17:53:08]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-02-04 17:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1662673002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-02-04 17:53:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1662673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1662673002/60001

[commit-bot: I haz the power, 2016-02-04 18:46:20]

Description was changed from

==========
Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

This change removes dependency on StreamChannelFactory and
P2PStreamSocket from ChannelDispatcherBase. This allow to use channel
dispatchers without the old message framing mechanism that doesn't
make sense for WebRTC-based protocol.

BUG=547158
==========

to

==========
Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

This change removes dependency on StreamChannelFactory and
P2PStreamSocket from ChannelDispatcherBase. This allow to use channel
dispatchers without the old message framing mechanism that doesn't
make sense for WebRTC-based protocol.

BUG=547158
==========

[commit-bot: I haz the power, 2016-02-04 18:46:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-04 18:47:37]

Description was changed from

==========
Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

This change removes dependency on StreamChannelFactory and
P2PStreamSocket from ChannelDispatcherBase. This allow to use channel
dispatchers without the old message framing mechanism that doesn't
make sense for WebRTC-based protocol.

BUG=547158
==========

to

==========
Add MessageChanneFactory interface and use it in ChannelDispatcherBase.

This change removes dependency on StreamChannelFactory and
P2PStreamSocket from ChannelDispatcherBase. This allow to use channel
dispatchers without the old message framing mechanism that doesn't
make sense for WebRTC-based protocol.

BUG=547158

Committed: https://crrev.com/786463e2ba806e5ed9d08b6ab9333210dd0b8772
Cr-Commit-Position: refs/heads/master@{#373571}
==========

[commit-bot: I haz the power, 2016-02-04 18:47:38]

Patchset 4 (id:??) landed as
https://crrev.com/786463e2ba806e5ed9d08b6ab9333210dd0b8772
Cr-Commit-Position: refs/heads/master@{#373571}