Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1661953002: bot_update: add depot_tools to PATH so that e.g. apply_issue can be found (reland #1) (Closed)

Created:
4 years, 10 months ago by Paweł Hajdan Jr.
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

bot_update: add depot_tools to PATH so that e.g. apply_issue can be found (reland #1) Original attempt: https://codereview.chromium.org/1660943002 Now adds depot_tools at the end of PATH to avoid issues with python on Windows. TBR=jochen BUG=437264 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M recipe_modules/bot_update/api.py View 1 chunk +4 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/off.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/svn_mode.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661953002/1
4 years, 10 months ago (2016-02-03 15:44:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298562
4 years, 10 months ago (2016-02-03 15:46:14 UTC) #5
Paweł Hajdan Jr.
TBR
4 years, 10 months ago (2016-02-03 15:47:23 UTC) #7
Paweł Hajdan Jr.
4 years, 10 months ago (2016-02-03 16:19:53 UTC) #8
Message was sent while issue was closed. 
For reference, this is how the failure looked like:

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...

'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as
an internal or external command,
operable program or batch file.

Powered by Google App Engine
This is Rietveld 408576698