bot_update: add depot_tools to PATH so that e.g. apply_issue can be found

bot_update: add depot_tools to PATH so that e.g. apply_issue can be found

BUG=437264
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556

[Paweł Hajdan Jr., 2016-02-03 14:26:57]

phajdan.jr@chromium.org changed reviewers:
+ jochen@chromium.org

[Paweł Hajdan Jr., 2016-02-03 14:26:58]

This fixes the error from
https://chromium-swarm.appspot.com/user/task/2cc02cf5cd9eb710 :

===Running apply_issue --root_dir build --issue 1597473002 --server
codereview.chromium.org --force --ignore_deps -v -v --no-auth --patchset 20001
--whitelist DEPS (attempt #1)===
In directory: /tmp/kitchen-059195992
Emitting flag file at /tmp/kitchen-059195992/update.flag
Traceback (most recent call last):
  File
"/tmp/runZAH0k1/build/scripts/slave/.recipe_deps/depot_tools/recipe_modules/bot_update/resources/bot_update.py",
line 1757, in <module>
    sys.exit(main())
  File
"/tmp/runZAH0k1/build/scripts/slave/.recipe_deps/depot_tools/recipe_modules/bot_update/resources/bot_update.py",
line 1731, in main
    step_text)
  File
"/tmp/runZAH0k1/build/scripts/slave/.recipe_deps/depot_tools/recipe_modules/bot_update/resources/bot_update.py",
line 1613, in checkout
    gclient_output = ensure_checkout(**checkout_parameters)
  File
"/tmp/runZAH0k1/build/scripts/slave/.recipe_deps/depot_tools/recipe_modules/bot_update/resources/bot_update.py",
line 1323, in ensure_checkout
    apply_issue_key_file, whitelist=[target])
  File
"/tmp/runZAH0k1/build/scripts/slave/.recipe_deps/depot_tools/recipe_modules/bot_update/resources/bot_update.py",
line 1129, in apply_rietveld_issue
    call(*cmd, tries=1)
  File
"/tmp/runZAH0k1/build/scripts/slave/.recipe_deps/depot_tools/recipe_modules/bot_update/resources/bot_update.py",
line 455, in call
    proc = subprocess.Popen(args, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
step returned non-zero exit code: 1

[Paweł Hajdan Jr., 2016-02-03 14:27:02]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 14:27:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1660943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1660943002/1

[commit-bot: I haz the power, 2016-02-03 14:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 14:29:11]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-02-03 14:48:36]

lgtm

[Paweł Hajdan Jr., 2016-02-03 14:49:28]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-02-03 14:49:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1660943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1660943002/1

[commit-bot: I haz the power, 2016-02-03 14:51:36]

Description was changed from

==========
bot_update: add depot_tools to PATH so that e.g. apply_issue can be found

BUG=437264
==========

to

==========
bot_update: add depot_tools to PATH so that e.g. apply_issue can be found

BUG=437264

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556
==========

[commit-bot: I haz the power, 2016-02-03 14:51:36]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298556

[kjellander_chromium, 2016-02-03 15:33:46]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1662763003/ by kjellander@chromium.org.

The reason for reverting is: I believe this breaks trybot patching on Windows. 

Example:
https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/...

Error: 
'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as
an internal or external command,
operable program or batch file.

I'm speculatively reverting..