chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc - Issue 1661713002: Remove the rest of HostDesktopType from c/b/ui/browser_finder.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

Issue 1661713002: Remove the rest of HostDesktopType from c/b/ui/browser_finder.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-11

Patch Set: linux adl Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc b/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

index f7088ae95659afe9b68bce8816833c6b36d932ac..fd0c25d0a455d034c1969f7f0ce9c66f7d225c84 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

@@ -76,32 +76,24 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, LastUsedProfileActivated) {

Browser* new_browser = NULL;

// The last used profile (the profile_2 in this case) must be active.

- ASSERT_EQ(1u, chrome::GetBrowserCount(profile_2,

- browser()->host_desktop_type()));

- new_browser = FindBrowserWithProfile(profile_2,

- browser()->host_desktop_type());

+ ASSERT_EQ(1u, chrome::GetBrowserCount(profile_2));

+ new_browser = chrome::FindBrowserWithProfile(profile_2);

ASSERT_TRUE(new_browser);

EXPECT_TRUE(new_browser->window()->IsActive());

// All other profiles browser should not be active.

- ASSERT_EQ(1u, chrome::GetBrowserCount(profile_1,

- browser()->host_desktop_type()));

- new_browser = FindBrowserWithProfile(profile_1,

- browser()->host_desktop_type());

+ ASSERT_EQ(1u, chrome::GetBrowserCount(profile_1));

+ new_browser = chrome::FindBrowserWithProfile(profile_1);

ASSERT_TRUE(new_browser);

EXPECT_FALSE(new_browser->window()->IsActive());

- ASSERT_EQ(1u, chrome::GetBrowserCount(profile_3,

- browser()->host_desktop_type()));

- new_browser = FindBrowserWithProfile(profile_3,

- browser()->host_desktop_type());

+ ASSERT_EQ(1u, chrome::GetBrowserCount(profile_3));

+ new_browser = chrome::FindBrowserWithProfile(profile_3);

ASSERT_TRUE(new_browser);

EXPECT_FALSE(new_browser->window()->IsActive());

- ASSERT_EQ(1u, chrome::GetBrowserCount(profile_4,

- browser()->host_desktop_type()));

- new_browser = FindBrowserWithProfile(profile_4,

- browser()->host_desktop_type());

+ ASSERT_EQ(1u, chrome::GetBrowserCount(profile_4));

+ new_browser = chrome::FindBrowserWithProfile(profile_4);

ASSERT_TRUE(new_browser);

EXPECT_FALSE(new_browser->window()->IsActive());

}