ui/native_theme/common_theme.h - Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/common_theme.h

Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restores hot-tracking of extension buttons in app menu with MD (nit) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('K') | « chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc ('k') | ui/native_theme/common_theme.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/native_theme/common_theme.h

diff --git a/ui/native_theme/common_theme.h b/ui/native_theme/common_theme.h

index b30b68d8686fcf068e2bc76b618ce800046a9a38..ca40765c67ca9e06d3938583a7d180f277113571 100644

--- a/ui/native_theme/common_theme.h

+++ b/ui/native_theme/common_theme.h

@@ -45,7 +45,8 @@ void NATIVE_THEME_EXPORT CommonThemePaintMenuBackground(SkCanvas* canvas,

void NATIVE_THEME_EXPORT CommonThemePaintMenuItemBackground(

SkCanvas* canvas,

NativeTheme::State state,

- const gfx::Rect& rect);

+ const gfx::Rect& rect,

+ const NativeTheme::MenuItemExtraParams& menu_item);

// Creates a gfx::Canvas wrapping an SkCanvas.

scoped_ptr<gfx::Canvas> NATIVE_THEME_EXPORT CommonThemeCreateCanvas(