chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc - Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restores hot-tracking of extension buttons in app menu with MD (nit) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('K') | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | ui/native_theme/common_theme.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

index 8c77e14ef1dd32ad4b424a40afc76da3be74ebb3..8a7e081039474fa07ef2d7bad2bc893234e01566 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

@@ -72,12 +72,8 @@ void ActivateOverflowedActionWithKeyboard(Browser* browser,

gfx::NativeWindow native_window =

views::MenuController::GetActiveInstance()->owner()->GetNativeWindow();

- // Send two key down events followed by the return key.

- // The two key down events target the toolbar action in the app menu.

- // TODO(devlin): Shouldn't this be one key down event?

- ui_controls::SendKeyPress(native_window,

- ui::VKEY_DOWN,

- false, false, false, false);

+ // Send a key down event followed by the return key.

+ // The key down event targets the toolbar action in the app menu.

ui_controls::SendKeyPress(native_window,

ui::VKEY_DOWN,

false, false, false, false);