Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2906)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restores hot-tracking of extension buttons in app menu with MD (nit) Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
index 40e9ee8617d4115976b399b3379419e9243fae82..37f514008e26851b92a522a89aa171d9ee59ba42 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
@@ -126,6 +126,11 @@ SkColor ToolbarActionView::GetInkDropBaseColor() const {
ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON);
}
+bool ToolbarActionView::ShouldShowInkDropHover() const {
+ return !delegate_->ShownInsideMenu() &&
Evan Stade 2016/03/01 00:00:08 This seems contrary to what you wrote on the bug:
varkha 2016/03/01 00:08:58 Yes, the immediate feedback is produced by a backg
+ views::MenuButton::ShouldShowInkDropHover();
+}
+
content::WebContents* ToolbarActionView::GetCurrentWebContents() const {
return delegate_->GetCurrentWebContents();
}

Powered by Google App Engine
This is Rietveld 408576698