Enables hot-tracking for overflow extension buttons in the app menu

chrome/browser/ui/views/toolbar/toolbar_action_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 108 matching lines @@
 void ToolbarActionView::RemoveInkDropLayer(ui::Layer* ink_drop_layer) {
   views::MenuButton::RemoveInkDropLayer(ink_drop_layer);
   image()->SetPaintToLayer(false);
 }
 
 SkColor ToolbarActionView::GetInkDropBaseColor() const {
   return GetThemeProvider()->GetColor(
       ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON);
 }
 
+bool ToolbarActionView::ShouldShowInkDropHover() const {
+  return !delegate_->ShownInsideMenu() &&

[Evan Stade, 2016/03/01 00:00:08]

This seems contrary to what you wrote on the bug: "mouse hot-tracking should
produce immediate feedback".

[varkha, 2016/03/01 00:08:58]

Yes, the immediate feedback is produced by a background created in app_menu.
This check here just disables the "other" hover that works on mouse enter / exit
with an animation.

+         views::MenuButton::ShouldShowInkDropHover();
+}
+
 content::WebContents* ToolbarActionView::GetCurrentWebContents() const {
   return delegate_->GetCurrentWebContents();
 }
 
 void ToolbarActionView::UpdateState() {
   content::WebContents* web_contents = GetCurrentWebContents();
   if (SessionTabHelper::IdForTab(web_contents) < 0)
     return;
 
   if (!view_controller_->IsEnabled(web_contents) &&
@@ skipping 190 matching lines @@
     if (menu_controller->in_nested_run()) {
       // There is another menu showing. Close the outermost menu (since we are
       // shown in the same menu, we don't want to close the whole thing).
       menu_controller->Cancel(views::MenuController::EXIT_OUTERMOST);
       return true;
     }
   }
 
   return false;
 }