Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1661453003: Mac overlays: Clean up partial swap code (Closed)

Created:
4 years, 10 months ago by ccameron
Modified:
4 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Mac overlays: Clean up partial swap code Remove use of linked_ptr, because it's not necessary now that we have C++11 support. Separate out functions to be a bit easier to read and follow. Remove unnecessary uses of RectF when Rect would do. BUG=533681 Review URL: https://codereview.chromium.org/1643043002 Cr-Commit-Position: refs/heads/master@{#372707} (cherry picked from commit 4d0aa96265cd731ddd74d43821df7feb9c55c1b1) Mac overlays: Move CALayerPartialDamageTree to its own file Direct copy-paste, no changes. BUG=533681 TBR=erikchen Review URL: https://codereview.chromium.org/1647523002 Cr-Commit-Position: refs/heads/master@{#371871} (cherry picked from commit 9a9014a549f126db8ad2dc0c0a1dc6bb246423ae) Mac overlays: Isolate partial swap support The logic to maintain a CALayer tree for partial swap support is complicated and should be removed, but that would compromise battery usage. Once the CoreAniamtion renderer is handling ~99% of the frames, we can remove it. In the mean time, isolate it. Create a CALayerPartialDamageTree to track the layer tree of partially swapped backbuffers. Do this in-place to minimize diffs, so that this patch can be reasonably reviewed. A follow-on patch will move it to a separate file. Slightly reorganize the logic so that CALayerPartialDamageTree matches the general structure of CALayerTree, where this a pending (not swapped) tree, a tree for each pending swap, and a tree for what is currently being displayed. BUG=533681 Review URL: https://codereview.chromium.org/1640093002 Cr-Commit-Position: refs/heads/master@{#371831} (cherry picked from commit 8aa00fc2a374fca3e9b9f34d838db7bb5f4fc088) Committed: https://chromium.googlesource.com/chromium/src/+/04f51c60da4daf1eb228d46954e4a8f9d23fbea1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -281 lines) Patch
A content/common/gpu/ca_layer_partial_damage_tree_mac.h View 1 chunk +56 lines, -0 lines 0 comments Download
A content/common/gpu/ca_layer_partial_damage_tree_mac.mm View 1 chunk +280 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.h View 6 chunks +3 lines, -15 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 12 chunks +35 lines, -266 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ccameron
Committed patchset #1 (id:1) manually as 04f51c60da4daf1eb228d46954e4a8f9d23fbea1.
4 years, 10 months ago (2016-02-02 20:35:41 UTC) #2
erikchen
On 2016/02/02 20:35:41, ccameron wrote: > Committed patchset #1 (id:1) manually as > 04f51c60da4daf1eb228d46954e4a8f9d23fbea1. Why ...
4 years, 10 months ago (2016-02-02 20:40:56 UTC) #3
ccameron
4 years, 10 months ago (2016-02-02 20:53:18 UTC) #4
Message was sent while issue was closed.
On 2016/02/02 20:40:56, erikchen wrote:
> On 2016/02/02 20:35:41, ccameron wrote:
> > Committed patchset #1 (id:1) manually as
> > 04f51c60da4daf1eb228d46954e4a8f9d23fbea1.
> 
> Why are you merging a refactor to a branch?

I'd rather have the branch be in a "feature completed and in known and
cleaned-up state" instead of "enough of the feature merged so that it works on
the branch". The branch already had a big chunk of crbug.com/533681's work, but
was in a halfway point between M48 and M50. This way, if there are any issues,
fixing and merging them will be easy.

Powered by Google App Engine
This is Rietveld 408576698